Fix crash on OS X node tests

platform/node/index.js

@@ -4,6 +4,7 @@
 
 var mbgl = require('../../lib/mapbox_gl_native.node');
 var constructor = mbgl.Map.prototype.constructor;
+var process = require('process');
 
 var Map = function(options) {
     if (!(options instanceof Object)) {
@@ -19,7 +20,12 @@ var Map = function(options) {
     return new constructor(Object.assign(options, {
         request: function(req) {
             request(req, function() {
-                req.respond.apply(req, arguments);
+                var args = arguments;
+                // Protect against `request` implementations that call the callback synchronously.
+                // http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony
+                process.nextTick(function() {
+                    req.respond.apply(req, args);
+                });
             });
         }
     }));

platform/node/src/node_request.cpp

@@ -122,19 +122,9 @@ void NodeRequest::HandleCallback(const Nan::FunctionCallbackInfo<v8::Value>& inf
 }
 
 void NodeRequest::Execute() {
-    asyncExecute = std::make_unique<mbgl::util::AsyncTask>([this] { doExecute(); Unref(); });
-    asyncExecute->send();
-
-    Ref();
-}
-
-void NodeRequest::doExecute() {
-    Nan::HandleScope scope;
-
     v8::Local<v8::Value> argv[] = { handle() };
 
     Nan::MakeCallback(Nan::To<v8::Object>(target->handle()->GetInternalField(1)).ToLocalChecked(), "request", 1, argv);
-    asyncExecute.reset();
 }
 
 NodeRequest::NodeAsyncRequest::NodeAsyncRequest(NodeRequest* request_) : request(request_) {

platform/node/src/node_request.hpp

@@ -8,9 +8,6 @@
 
 #include <mbgl/storage/resource.hpp>
 #include <mbgl/storage/file_source.hpp>
-#include <mbgl/util/async_task.hpp>
-
-#include <memory>
 
 namespace node_mbgl {
 
@@ -38,12 +35,9 @@ class NodeRequest : public Nan::ObjectWrap,
     void Execute();
 
 private:
-    void doExecute();
-
     NodeMap* target;
     mbgl::FileSource::Callback callback;
     NodeAsyncRequest* asyncRequest = nullptr;
-    std::unique_ptr<mbgl::util::AsyncTask> asyncExecute;
 };
 
 }