This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix several issues in node bindings #9554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsudekum
reviewed
Jul 19, 2017
platform/node/index.js
Outdated
| // Protect ourselves from `request` implementations that try to release Zalgo. | ||
| // http://blog.izs.me/post/59142742143/designing-apis-for-asynchrony | ||
| try { | ||
| request(req, function() { |
There was a problem hiding this comment.
Wrapping an async function in a try/catch always set off a🚨 in my head. Which function in here can throw?
There was a problem hiding this comment.
Nothing should throw. This is the API defending itself against badly behaved request functions that do throw -- better to be defensive than crash in this situation.
kkaefer
added
Core
kkaefer
reviewed
Jul 21, 2017
| var map = new mbgl.Map({ | ||
| request: function() { | ||
| throw new Error('message'); | ||
| } |
There was a problem hiding this comment.
Can we add a test that first calls the callback, and then throws? This should ensure that the callback doesn't get invoked twice. Maybe also a test that has two invocations of callback.
| }); | ||
| map.load(mockfs.style_vector); | ||
| map.render({ zoom: 16 }, function(err, pixels) { | ||
| t.error(err); |
There was a problem hiding this comment.
This test passes even without the code changes. Can we add a check to make sure the render function is called only once ?
asheemmamoowala
approved these changes
Jul 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastErrorstate when appropriate -- this was causing spurious errors when reusing aMapobject for multiple renders.