Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Fix geojson source proguard issue #9577

Merged
merged 1 commit into from
Jul 24, 2017
Merged

[android] Fix geojson source proguard issue #9577

merged 1 commit into from
Jul 24, 2017

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 added the Android Mapbox Maps SDK for Android label Jul 21, 2017
@Guardiola31337 Guardiola31337 added this to the android-v5.2.0 milestone Jul 21, 2017
@Guardiola31337 Guardiola31337 requested review from tobrun and cammace July 21, 2017 11:51
@Guardiola31337 Guardiola31337 mentioned this pull request Jul 21, 2017
Closed
@sddamico
Copy link

Should this not be com.google.gson.**? seems like an aggressive keep if the concern is gson specifically...

tobrun
tobrun suggested changes Jul 24, 2017
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9577 (comment)

@Guardiola31337 Guardiola31337 force-pushed the pg-9569-geojson-proguard branch from a10afdf to d7036f9 Compare July 24, 2017 07:25
@Guardiola31337
Copy link
Contributor Author

@tobrun fixed it and tested it.

@sddamico thanks for the suggestion 👍

@tobrun
Copy link
Member

tobrun commented Jul 24, 2017

Moving this to the 5.1.2 milestone, don't worry about cherry-picking this, will go through the milestone before releasing.

@tobrun tobrun modified the milestones: android-v5.1.2, android-v5.2.0 Jul 24, 2017
@Guardiola31337 Guardiola31337 merged commit 541712a into master Jul 24, 2017
@Guardiola31337 Guardiola31337 deleted the pg-9569-geojson-proguard branch July 24, 2017 10:08
tobrun pushed a commit that referenced this pull request Jul 26, 2017
@Guardiola31337 @tobrun
[android] fix geojson source proguard issue (#9569) (#9577)
6f2bb42
tobrun pushed a commit that referenced this pull request Jul 28, 2017
@Guardiola31337 @tobrun
[android] fix geojson source proguard issue (#9569) (#9577)
5e6ca3a
@tobrun tobrun mentioned this pull request Aug 2, 2017
Closed
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

@cammace cammace Awaiting requested review from cammace

Assignees
No one assigned
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v5.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@Guardiola31337 @sddamico @tobrun