Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Validate Marker before opening InfoWindow #9586

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 24, 2017

Was able to hit a crash when clicking a marker and closing the Activity hosting the MapView quickly after. This PR adds a check to validate if Marker is still valid to show an InfoWindow when we get the results back from queryPointAnnotations.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 24, 2017
@tobrun tobrun added this to the android-v5.1.2 milestone Jul 24, 2017
@tobrun tobrun self-assigned this Jul 24, 2017
@tobrun tobrun requested a review from Guardiola31337 July 24, 2017 09:09
@tobrun tobrun force-pushed the tvn-invalid-marker-infowindow branch from 9fa829a to 8b00d4f Compare July 24, 2017 09:21
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobrun tobrun merged commit e8ad7b6 into master Jul 24, 2017
@tobrun tobrun deleted the tvn-invalid-marker-infowindow branch July 24, 2017 11:40
@tobrun tobrun mentioned this pull request Aug 2, 2017
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants