This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Move ZoomButtonController creation to view initalisation #9587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| MapZoomButtonController(@NonNull View ownerView, @NonNull UiSettings uiSettings, @NonNull OnZoomListener listener) { | ||
| super(ownerView); | ||
| MapZoomButtonController(@NonNull View ownerView) { |
There was a problem hiding this comment.
- Why not passing
ZoomButtonsControllerinstead?
tobrun
force-pushed
the
tvn-view-initalisation-mapzoombuttoncontroller
branch
from
41889d0 to
8175da0
Compare
tobrun
force-pushed
the
tvn-view-initalisation-mapzoombuttoncontroller
branch
from
8175da0 to
1b0567d
Compare
|
done with 1b0567d |
20 tasks
20 tasks
20 tasks
This was referenced Nov 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #9462 we started to make a distinction between view versus map initialization.
MapZoomButtonControllerwas created as part of the map initialization while it's actually a view itself. This PR also changes from inheritance to composition.