Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] Fix added to map checks #9602

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Jul 25, 2017

  • Fixes added to map checks because LongSparseArray#indexOfKey could return a negative number when the specified key is not mapped

👀 @tobrun

@Guardiola31337 Guardiola31337 added Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug labels Jul 25, 2017
@Guardiola31337 Guardiola31337 added this to the android-v5.1.2 milestone Jul 25, 2017
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems we are repeating ourselves a bit, can this be extracted into a util or a parent class?

…could return a negative number when the specified key is not mapped
@Guardiola31337
Copy link
Contributor Author

@tobrun you're right 👍 Thanks for flagging!

I addressed your comment in 8858bb5

@Guardiola31337 Guardiola31337 merged commit 0e0536a into master Jul 25, 2017
@Guardiola31337 Guardiola31337 deleted the pg-fix-added-to-map-checks branch July 25, 2017 11:01
tobrun pushed a commit that referenced this pull request Jul 26, 2017
…could return a negative number when the specified key is not mapped (#9602)
tobrun pushed a commit that referenced this pull request Jul 28, 2017
…could return a negative number when the specified key is not mapped (#9602)
@tobrun tobrun mentioned this pull request Aug 2, 2017
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants