Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Solve lint issues, reduce baseline #9627

Merged
merged 3 commits into from
Jul 28, 2017
Merged

Solve lint issues, reduce baseline #9627

merged 3 commits into from
Jul 28, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jul 27, 2017

This PR resolves lint issues, reduces the baseline and create follow up tickets when required.

More information in #9318.

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jul 27, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Jul 27, 2017
@tobrun tobrun self-assigned this Jul 27, 2017
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rock clapping

Minor typo.

android:maxEms="17"
android:textColor="@android:color/black"
android:textSize="18sp"
android:textStyle="bold"/>

<TextView
<TextViewI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo *TextViewI

@tobrun
Copy link
Member Author

tobrun commented Jul 27, 2017

CI is currently failing as I didn't handle the wear module for this PR.
This PR requires #9618 to be merged first.

@tobrun tobrun force-pushed the tvn-fix-lint branch 2 times, most recently from f4e2f18 to 03ae2d3 Compare July 27, 2017 12:26
@zugaldia
Copy link
Member

bitmoji

@tobrun tobrun merged commit 685b8b2 into master Jul 28, 2017
@tobrun tobrun deleted the tvn-fix-lint branch July 28, 2017 17:36
@tobrun tobrun mentioned this pull request Aug 7, 2017
1 task
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
21 tasks
This was referenced Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants