Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update example of camera zoom function on a symbol layer. #9743

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Update example of camera zoom function on a symbol layer. #9743

merged 1 commit into from
Aug 10, 2017

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Aug 10, 2017

This PR replaces the AddRemoveMarkerActivity with a SymbolLayer implementation that does the same with a symbollayer and with scale:

ezgif com-video-to-gif 32

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Aug 10, 2017
@tobrun tobrun added this to the android-v5.2.0 milestone Aug 10, 2017
@tobrun tobrun self-assigned this Aug 10, 2017
@tobrun tobrun requested a review from Guardiola31337 August 10, 2017 09:09
Guardiola31337
Guardiola31337 suggested changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor detail. What about replacing magic numbers (literals in general including Strings) with constants with a particular meaning?

@tobrun tobrun force-pushed the tvn-update-change-symbol branch from ef21bb2 to 171a0cb Compare August 10, 2017 11:36
@tobrun
Copy link
Member Author

tobrun commented Aug 10, 2017

@Guardiola31337 Great catch, code has been updated.

Guardiola31337
Guardiola31337 approved these changes Aug 10, 2017
View reviewed changes
Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@tobrun tobrun merged commit 98f7d4d into master Aug 10, 2017
@tobrun tobrun deleted the tvn-update-change-symbol branch August 10, 2017 16:56
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 6, 2017
Closed
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 19, 2017
Closed
20 tasks
@Guardiola31337 Guardiola31337 mentioned this pull request Oct 26, 2017
Closed
20 tasks
@tobrun tobrun mentioned this pull request Nov 3, 2017
Closed
21 tasks
This was referenced Nov 14, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Guardiola31337 Guardiola31337 Guardiola31337 approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Milestone
android-v5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tobrun @Guardiola31337