Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Set Default MaxZoom to 22 #9821

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Set Default MaxZoom to 22 #9821

merged 1 commit into from
Aug 21, 2017

Conversation

asheemmamoowala
Copy link
Contributor

Closes #8318.

Now that #7155 has been addressed, this change can go in with the caveat that we still have a related open issue: #9820

@asheemmamoowala asheemmamoowala merged commit d21f196 into master Aug 21, 2017
@asheemmamoowala asheemmamoowala deleted the default-max-zoom-22 branch August 21, 2017 22:01
@@ -247,7 +247,8 @@ MGL_EXPORT IB_DESIGNABLE
If the value of this property is smaller than that of the `minimumZoomLevel`
property, the behavior is undefined.

The default value of this property is 20.
The default value of this property is 22. The upper bound for this property
is 25.5.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The corresponding iOS comment needs to be updated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is happening in #9835.

@@ -247,7 +247,8 @@ MGL_EXPORT IB_DESIGNABLE
If the value of this property is smaller than that of the `minimumZoomLevel`
property, the behavior is undefined.

The default value of this property is 20.
The default value of this property is 22. The upper bound for this property
is 25.5.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I originally left out the upper bound because setting the property to something higher like 30 would silently get capped to 25.5 anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1ec5 Its nice to know it up front in that case, since there is no other way for a developer to know why its been capped.

@friedbunny friedbunny added Core The cross-platform C++ core, aka mbgl iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS and removed iOS Mapbox Maps SDK for iOS labels Aug 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Core The cross-platform C++ core, aka mbgl macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants