This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Set Default MaxZoom to 22 #9821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
approved these changes
Aug 21, 2017
1ec5
reviewed
Aug 22, 2017
| @@ -247,7 +247,8 @@ MGL_EXPORT IB_DESIGNABLE | |||
| If the value of this property is smaller than that of the `minimumZoomLevel` | |||
| property, the behavior is undefined. | |||
|
|
|||
| The default value of this property is 20. | |||
| The default value of this property is 22. The upper bound for this property | |||
| is 25.5. | |||
There was a problem hiding this comment.
The corresponding iOS comment needs to be updated.
| @@ -247,7 +247,8 @@ MGL_EXPORT IB_DESIGNABLE | |||
| If the value of this property is smaller than that of the `minimumZoomLevel` | |||
| property, the behavior is undefined. | |||
|
|
|||
| The default value of this property is 20. | |||
| The default value of this property is 22. The upper bound for this property | |||
| is 25.5. | |||
There was a problem hiding this comment.
I think I originally left out the upper bound because setting the property to something higher like 30 would silently get capped to 25.5 anyways.
There was a problem hiding this comment.
@1ec5 Its nice to know it up front in that case, since there is no other way for a developer to know why its been capped.
friedbunny
added
Core
asheemmamoowala
pushed a commit
that referenced
this pull request
Aug 22, 2017
asheemmamoowala
pushed a commit
that referenced
this pull request
Aug 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8318.
Now that #7155 has been addressed, this change can go in with the caveat that we still have a related open issue: #9820