This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Fix is download complete #9913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
force-pushed
the
pg-offline-on-status-changed-twice
branch
from
626b0dc to
d15463d
Compare
… and required resources match and the download state is inactive)
Guardiola31337
force-pushed
the
pg-offline-on-status-changed-twice
branch
from
d15463d to
eb1c2ed
Compare
Guardiola31337
changed the title
zugaldia
approved these changes
Sep 7, 2017
tobrun
pushed a commit
that referenced
this pull request
Sep 25, 2017
… and required resources match and the download state is inactive) (#9913)
tobrun
pushed a commit
that referenced
this pull request
Sep 26, 2017
… and required resources match and the download state is inactive) (#9913)
mappy-mobile
pushed a commit
to Mappy/mapbox-gl-native
that referenced
this pull request
Oct 3, 2017
….1.4 * release-ios-v3.6.0-android-v5.1.0: (36 commits) [android] [auto] Update properties to version 5.1.4 in preparation for build. [android] - latLngBounds test [android] - update changelog for 5.1.4 release. bump MAS version number to 2.2.3 (mapbox#9901) [android] fix is download complete (a download is complete when count and required resources match and the download state is inactive) (mapbox#9913) [android] - avoid adding duplicate points to bounds [android] Clear out mapCallback's OnMapReadyCallbacks on onDestroy [android] - harden offline region deletion Do not check connection if it is local request [android] - disable rotation gesture when pinch zooming macos-v0.5.1 [ios] Bump podspec to 3.6.4 (mapbox#10059) [android, ios, macos] Updated translations [core] make sure tiles are not treated as complete until all worker operations completed [core] keep tiles renderable even if a subsequent error occurs [ios] Be sure to get a BOOL value for nullable dict keys iosv3.6.3 podspec bump (mapbox#10008) [ios, macos] Deprecate trafficDayStyleURL and trafficNightStyleURL (mapbox#9918) [ios] Use constraints to manage ornament view placement (again) (mapbox#9995) [ios] Canned spam coming from Transifex ... # Conflicts: # platform/android/MapboxGLAndroidSDK/proguard-rules.pro # platform/android/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/maps/MapGestureDetector.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9908
Prevents callingobserver->statusChanged(status);when the download is deactivated which caused two calls toonStatusChangedmakingstatus.isComplete()truetwice as well.OfflineRegionStatus#isComplete:completedResourceCountandrequiredResourceCountmatch and thedownloadStateisOfflineRegion.STATE_INACTIVEwhich prevents reporting is completed twice.👀 @fabian-guerra @zugaldia