Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Make "icon-offset" units more intuitive #84

Closed
ansis opened this issue Jul 8, 2014 · 1 comment
Closed

Make "icon-offset" units more intuitive #84

ansis opened this issue Jul 8, 2014 · 1 comment
Labels
breaking change

Comments

@ansis
Copy link
Contributor

ansis commented Jul 8, 2014

from #83

The only thing that may cause confusion is that text-offset is in ems, while icon-offset is in pixels. But maybe that's not important.

The current units for icon-offset aren't even exactly pixels. If the icon gets scaled with icon-size then the offset also gets scaled. An icon with "icon-offset": 6 and "icon-size": 0.5 actually has an offset of 3 pixels.

For now the units need to be relative to the unscaled size, not absolute values, but maybe we should changes the units of icon-offset to a fraction of the original size.
jfirebaugh added a commit that referenced this issue Nov 3, 2014
@jfirebaugh
text-offset is ems, icon-offset is not pixels
e015bf8 
#84
@jfirebaugh jfirebaugh mentioned this issue Mar 7, 2016
Closed
@jfirebaugh jfirebaugh mentioned this issue Dec 8, 2016
Closed
@lucaswoj lucaswoj changed the title icon-offset units Units on icon-offset are confusing Dec 22, 2016
@lucaswoj lucaswoj changed the title Units on icon-offset are confusing Units on "icon-offset" are confusing Dec 22, 2016
@lucaswoj lucaswoj changed the title Units on "icon-offset" are confusing Make "icon-offset" units more intuitive Dec 22, 2016
@lucaswoj lucaswoj mentioned this issue Feb 1, 2017
Closed
@lucaswoj
Copy link

lucaswoj commented Feb 1, 2017

This issue was moved to mapbox/mapbox-gl-js#4078

@lucaswoj lucaswoj closed this as completed Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucaswoj @ansis