This repository has been archived by the owner on Apr 10, 2018. It is now read-only.
update validation for new data + zoom driven functions #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Per chat with @scothis, we're going to relax some of these restrictions. Ping me when this PR is ready for 👀. |
| valueSpec: {type: 'number'}, | ||
| style: options.style, | ||
| styleSpec: options.styleSpec | ||
| })); |
There was a problem hiding this comment.
Should we also validate the value property, if it is present?
There was a problem hiding this comment.
I think we can assert that
valueis either a string or a number- no keys other than
valueandzoomare present
Nope, you've captured it all in code 👍. |
|
Was the change to |
|
This is good to 🚢 once you add a test for the new zoom-and-feature function syntax. |
|
d45b873 adds validation tests for zoom+feature functions |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👀 @lucaswoj