Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Add text-pitch-alignment, refs #459 #460

Merged
merged 2 commits into from
Jun 11, 2016
Merged

Add text-pitch-alignment, refs #459 #460

merged 2 commits into from
Jun 11, 2016

Conversation

yhahn
Copy link
Member

@yhahn yhahn commented Jun 9, 2016

@jfirebaugh jfirebaugh changed the title [notready] Add text-rotation-alignment, refs #459 [notready] Add text-pitch-alignment, refs #459 Jun 9, 2016
@lucaswoj
Copy link

lucaswoj commented Jun 9, 2016

LGTM 🚢

@yhahn
Copy link
Member Author

yhahn commented Jun 10, 2016

@lucaswoj @jfirebaugh per our discussion yesterday,

  • Removed the default value for text-pitch-alignment
  • Updated the description to describe how the default does text-rotation-alignment => text-pitch-alignment

I think the "don't lie in the spec" approach is a good place to start and figuring out a more robust way to specify these edge cases in the spec a quest we can take on in the future.

@yhahn yhahn changed the title [notready] Add text-pitch-alignment, refs #459 Add text-pitch-alignment, refs #459 Jun 10, 2016
@yhahn yhahn merged commit d4e6e98 into mb-pages Jun 11, 2016
@yhahn yhahn deleted the unskew branch June 11, 2016 03:04
@yhahn yhahn removed the in progress label Jun 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants