Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use forked Pigeon #249

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Use forked Pigeon #249

merged 3 commits into from
Sep 29, 2023

Conversation

evil159
Copy link
Contributor

@evil159 evil159 commented Sep 29, 2023

This PR fixes typecasting crashes for nested collections in generated decoding code by adopting a forked version of Pigeon - https://github.com/evil159/packages

The plan is to use the fork for the time being while proposing this change to be adopted by the mainstream Pigeon.

@evil159
Copy link
Contributor Author

evil159 commented Sep 29, 2023

Addresses #150

Copy link
Collaborator

@yunikkk yunikkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @evil159 !

@yunikkk yunikkk merged commit 8bbd28a into main Sep 29, 2023
@yunikkk yunikkk deleted the rl/use_forked_pigeon branch September 29, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants