Ignore event subsription updates while platform view is creating #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evil159
force-pushed
the
rl/subscribe_map_events_crash_fix
branch
from
db3430e
to
0201ade
Compare
evil159
force-pushed
the
rl/subscribe_map_events_crash_fix
branch
from
320f4a7
to
4d1dfb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Platform view creation is asynchronous and in case widget state updates before the view is created we can get an exception trying to send a message to subscribe for events.
The fix is to ignore event subsription updates while platform view is creating.
Addresses #657.
What is the motivation and context behind this change?
Pull request checklist: