Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Core & Common #732

Merged
merged 4 commits into from
Oct 3, 2021
Merged

Upgrade Core & Common #732

merged 4 commits into from
Oct 3, 2021

Conversation

macdrevx
Copy link
Contributor

@macdrevx macdrevx commented Oct 2, 2021

Fixes: #571

Pull request checklist:

  • Briefly describe the changes in this PR.
  • Document any changes to public APIs.
  • Apply changelog label ('breaking change', 'bug 🪲', 'build', 'docs', 'feature 🍏', 'performance ⚡', 'testing 💯') or use the label 'skip changelog'
  • Update the changelog

Summary of changes

  • Updates to MapboxCoreMaps v10.0.0 and MapboxCommon v20.0.0.

Public API Changes

  • Core and Common APIs that accept user-defined implementations of protocols now hold strong references to the provided objects. Please audit your usage of the following protocols and make any required changes to avoid memory leaks: CustomLayerHost, ElevationData, MapClient, MBMMetalViewProvider, Observer, OfflineRegionObserver, HttpServiceInterceptorInterface, HttpServiceInterface, LogWriterBackend, OfflineSwitchObserver, ReachabilityInterface, TileStoreObserver

Other changes

  • Updates CustomLayerExample, OfflineRegionManagerExample, and SceneKitExample to avoid memory leaks
  • MapView's stored reference to mapClient is no longer necessary and has been removed.
  • eventHandlers properties of MapboxMap and Snapshotter are now lets.
  • Reorganized some comments
  • Removed some unnecessary MARK separating lines
  • Disabled part of a MigrationGuideIntegrationTests test case that invoked HttpServiceFactory.setUserDefinedForCustom to avoid modifying shared global state that could impact other tests.
  • Deleted unused DelegatingObserver and associated delegate protocol

@macdrevx macdrevx added the skip changelog Add this label if this item does not need to be included in the changelog label Oct 2, 2021
@macdrevx macdrevx requested a review from jmkiley October 2, 2021 18:45
[run device tests]
[run app device tests]
Copy link
Contributor

@neelmistry94 neelmistry94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and feedback

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Sources/MapboxMaps/Snapshot/Snapshotter.swift Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog Add this label if this item does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpServiceFactory should retain a strong reference to custom HttpServiceInterface implementations
2 participants