Added nav-native ETAs #1412
Merged
Added nav-native ETAs #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devotaaabel
force-pushed
the
devota-fix-etas
branch
2 times, most recently
from
9a88d64
to
f740d12
Compare
devotaaabel
force-pushed
the
devota-fix-etas
branch
from
f740d12
to
b626b27
Compare
danesfeder
force-pushed
the
devota-fix-etas
branch
from
1a641d2
to
9fad7ad
Compare
danesfeder
approved these changes
Oct 13, 2018
| public double durationRemaining() { | ||
| return (1 - fractionTraveled()) * routeLeg().duration(); | ||
| } | ||
| public abstract double durationRemaining(); |
There was a problem hiding this comment.
I believe this is breaking SemVer @devotaaabel @danesfeder
Guardiola31337
added
the
backwards incompatible
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.