Replace LocationLayerPlugin with LocationComponent #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
added
refactor
backwards incompatible
danesfeder
force-pushed
the
dan-location-component
branch
2 times, most recently
from
ef59dc9
to
d72fe3e
Compare
|
@Guardiola31337 javadoc is updated here and this is ready for 👀 |
LukasPaczos
reviewed
Oct 23, 2018
| if (locationLayerPlugin != null) { | ||
| locationLayerPlugin.onStart(); | ||
| if (mapboxMap != null) { | ||
| mapboxMap.getLocationComponent().onStart(); |
There was a problem hiding this comment.
LocationComponent#onStart is for the Maps SDK's internal use only and doesn't need to be called manually from the client's perspective :)
| if (locationLayerPlugin != null) { | ||
| locationLayerPlugin.onStop(); | ||
| if (mapboxMap != null) { | ||
| mapboxMap.getLocationComponent().onStop(); |
| if (locationLayerPlugin != null) { | ||
| locationLayerPlugin.onStart(); | ||
| if (mapboxMap != null) { | ||
| mapboxMap.getLocationComponent().onStart(); |
| if (locationLayerPlugin != null) { | ||
| locationLayerPlugin.onStop(); | ||
| if (mapboxMap != null) { | ||
| mapboxMap.getLocationComponent().onStop(); |
| if (locationLayer != null) { | ||
| locationLayer.onStart(); | ||
| if (mapboxMap != null) { | ||
| mapboxMap.getLocationComponent().onStart(); |
| if (locationLayer != null) { | ||
| locationLayer.onStart(); | ||
| if (mapboxMap != null) { | ||
| mapboxMap.getLocationComponent().onStart(); |
| if (locationLayer != null) { | ||
| locationLayer.onStop(); | ||
| if (mapboxMap != null) { | ||
| mapboxMap.getLocationComponent().onStop(); |
| @@ -147,7 +147,7 @@ public void clearMarkers() { | |||
| * @param location to update the icon and query the map | |||
| */ | |||
| public void updateLocation(Location location) { | |||
| locationLayer.forceLocationUpdate(location); | |||
| mapboxMap.getLocationComponent().forceLocationUpdate(location); | |||
There was a problem hiding this comment.
For testing purposes, this should probably also use the injected LocationComponent.
| @@ -393,7 +383,7 @@ public void updateWaynameQueryMap(boolean isEnabled) { | |||
| * accounting for the lifecycle. | |||
| */ | |||
| public void onStart() { | |||
| locationLayer.onStart(); | |||
| locationComponent.onStart(); | |||
| @@ -403,7 +393,7 @@ public void onStart() { | |||
| * accounting for the lifecycle. | |||
| */ | |||
| public void onStop() { | |||
| locationLayer.onStop(); | |||
| locationComponent.onStop(); | |||
danesfeder
force-pushed
the
dan-location-component
branch
from
d72fe3e
to
60e1b66
Compare
|
Thanks for the great feedback @LukasPaczos! Should be all addressed now. @Guardiola31337 this is ready for final 👀 when you have a chance |
danesfeder
force-pushed
the
dan-location-component
branch
from
60e1b66
to
20ee3fc
Compare
Guardiola31337
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Other than a couple of nits, this looks good to me 🚀
Thanks @LukasPaczos for implementing this as a component from the Maps SDK and @danesfeder for integrating it! This is awesome 🙇
| * @param locationLayer for managing camera mode | ||
| * @param mapboxMap for moving the camera | ||
| * @param navigation for listening to location updates | ||
| * @param locationComponent for managing camera mode | ||
| * @since 0.6.0 |
There was a problem hiding this comment.
Should we mark this change in the @since?
| * @param mapboxMap for moving the camera | ||
| * @param locationLayer for managing camera mode | ||
| * @param mapboxMap for moving the camera | ||
| * @param locationComponent for managing camera mode |
danesfeder
force-pushed
the
dan-location-component
branch
from
20ee3fc
to
c9bd57a
Compare
danesfeder
force-pushed
the
dan-location-component
branch
from
c9bd57a
to
6c8a910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1431
This PR replaces the
LocationLayerPluginwithMapboxMap#getLocationComponent. We no longer need to pull in a separate dependency at this is now part of the Maps SDK. Noting (and also labeled) that this PR breaks SEMVER in a few places that we can note in the release notes.