Use most recent raw Location when building snapped Location #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Nov 12, 2018
| @Override | ||
| public Location getSnappedLocation(Location location, RouteProgress routeProgress) { | ||
| // No impl | ||
| return location; | ||
| } | ||
|
|
||
| public Location getSnappedLocationWith(NavigationStatus status) { | ||
| return buildSnappedLocation(status); | ||
| public Location getSnappedLocationWith(NavigationStatus status, Location rawLocation) { |
There was a problem hiding this comment.
This should be marked as SemVer.
danesfeder
force-pushed
the
dan-snap-location-fix
branch
from
291326b
to
555e691
Compare
danesfeder
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1518
We can use the most recent raw
Locationupdate to build the snappedLocation. With the current creation of the snapped location, we omit a lot of data that a developer may be looking for in the snapped location provided by theProgressChangeListener.Eventually, this can be provided by the
NavigationStatus, but we can use this approach until that is added upstream.cc @kevinkreiser