Fix UI tests with DirectionsRoute test fixture #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guardiola31337
approved these changes
Nov 26, 2018
danesfeder
force-pushed
the
dan-flaky-test
branch
from
4956fcb
to
66e1968
Compare
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
=========================================
Coverage 19.17% 19.17%
Complexity 684 684
=========================================
Files 184 184
Lines 9379 9379
Branches 608 608
=========================================
Hits 1798 1798
Misses 7398 7398
Partials 183 183 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1209
We previously ran into various issues with our UI tests around the Directions API network calls / double initialization of the
NavigationViewcausing map crashes.This PR adjusts how we set up the
OnNavigationReadyIdlingResourceand also how we start navigation with aDirectionsRoute(now comes from a fixture in the assets folder).