Fix milestone / progress listener leaks from NavigationView #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danesfeder
force-pushed
the
dan-listener-leak
branch
from
ca8a2b0
to
2cceb00
Compare
Codecov Report
@@ Coverage Diff @@
## master #1552 +/- ##
============================================
+ Coverage 22.48% 22.75% +0.27%
- Complexity 687 689 +2
============================================
Files 182 182
Lines 8097 8102 +5
Branches 599 599
============================================
+ Hits 1821 1844 +23
+ Misses 6093 6075 -18
Partials 183 183 |
danesfeder
requested review from
Guardiola31337
and removed request for
devotaaabel
|
@devotaaabel transferring review ownership to @Guardiola31337 here while we bring offline home and so we can get it in this weeks release. |
danesfeder
force-pushed
the
dan-listener-leak
branch
from
2cceb00
to
c97a939
Compare
Guardiola31337
approved these changes
Nov 29, 2018
There was a problem hiding this comment.
Looks good to me 👍
Thanks for squashing this 🐛 @danesfeder 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1279
This leak was caused by a new
ProgressChangeListenerbeing added each time navigation was started with theNavigationViewinEndNavigationActivity.If we stop navigation, we should also remove the listeners if we require them when starting as well.