Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for DynamicCamera in ExampleViewModel shutdown #1560

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

danesfeder
Copy link
Contributor

No description provided.

@danesfeder danesfeder added bug Defect to be fixed. ✓ ready for review labels Nov 28, 2018
@danesfeder danesfeder added this to the v0.24.0 milestone Nov 28, 2018
@danesfeder danesfeder self-assigned this Nov 28, 2018
Copy link
Contributor

@devotaaabel devotaaabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround!

@devotaaabel
Copy link
Contributor

@danesfeder tests failing

@codecov-io
Copy link

Codecov Report

Merging #1560 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1560   +/-   ##
=========================================
  Coverage     19.46%   19.46%           
  Complexity      687      687           
=========================================
  Files           183      183           
  Lines          9354     9354           
  Branches        602      602           
=========================================
  Hits           1821     1821           
  Misses         7350     7350           
  Partials        183      183

@danesfeder danesfeder merged commit 702cf5f into master Nov 28, 2018
@danesfeder danesfeder deleted the dan-cast-camera branch November 28, 2018 17:33
@Guardiola31337 Guardiola31337 mentioned this pull request Nov 30, 2018
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants