Fix the progressUpdateListener for Tile Pack Unpacking #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
requested review from
devotaaabel,
danesfeder and
Guardiola31337
devotaaabel
reviewed
Nov 29, 2018
| } | ||
| while (progress < 100L); |
There was a problem hiding this comment.
its to make sure it gets to 100% before ending the progress update task
Codecov Report
@@ Coverage Diff @@
## devota-route-tile-download #1567 +/- ##
================================================================
- Coverage 22.39% 22.39% -0.01%
Complexity 689 689
================================================================
Files 189 189
Lines 8233 8235 +2
Branches 606 606
================================================================
Hits 1844 1844
- Misses 6206 6208 +2
Partials 183 183 |
Guardiola31337
approved these changes
Nov 29, 2018
There was a problem hiding this comment.
Looks good to me 👍
Thanks for squashing this one @kevinkreiser 🙇
devotaaabel
approved these changes
Nov 29, 2018
|
Going ahead and merging here! Thanks again @kevinkreiser |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to describe here, just that we had two small issues. We needed to use floating point division so that when we cast back to long it doesn't truncate to
0and we also needed to invert the percentage since we are counting down to0from the full size of the file as its being truncated.