Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permissions and preferences for ExampleActivity #1581

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

danesfeder
Copy link
Contributor

This updates the test app to request request location updates after permissions have been granted for the first time. It also updates ExampleActivity to update the offline version in onResume and only if it's different from the previous version.

I also consolidated the offline settings / download in the navigation preference fragment. If we'd rather have the download activity in the list and the offline disabled in the settings list, we can move that back. I just thought it made sense to have everything together from an app user perspective.

Permissions:

ezgif com-video-to-gif

Download:

ezgif com-video-to-gif copy 2

Route:

ezgif com-video-to-gif copy

cc @Guardiola31337 @kevinkreiser

@danesfeder danesfeder added bug Defect to be fixed. ✓ ready for review labels Nov 30, 2018
@danesfeder danesfeder self-assigned this Nov 30, 2018
@codecov-io
Copy link

Codecov Report

Merging #1581 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1581   +/-   ##
=========================================
  Coverage     22.56%   22.56%           
  Complexity      694      694           
=========================================
  Files           189      189           
  Lines          8230     8230           
  Branches        606      606           
=========================================
  Hits           1857     1857           
  Misses         6190     6190           
  Partials        183      183

Copy link
Contributor

@Guardiola31337 Guardiola31337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @danesfeder 👏

I do also think that the flow is clearer for end users.

@danesfeder danesfeder merged commit 803c27d into master Nov 30, 2018
@danesfeder danesfeder deleted the dan-example-updates branch November 30, 2018 20:00
@Guardiola31337 Guardiola31337 mentioned this pull request Dec 3, 2018
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants