Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mapbox-android-sdk version to 8.2.1 #2013

Merged
merged 1 commit into from
Jul 31, 2019
Merged

Conversation

Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Jul 29, 2019

Description

Bumps mapbox-android-sdk version to 8.2.1

Fixes #2006

  • I have added any issue links
  • I have added all related labels (bug, feature, new API(s), SEMVER, etc.)
  • I have added the appropriate milestone and project boards

Goal

Getting the latest version from mapboxMapSdk including the new features and bug fixes.

Implementation

Bumping the mapboxMapSdk version to 8.2.1 in dependencies.gradle

Testing

Please describe the manual tests that you ran to verify your changes

  • I have tested locally (including SNAPSHOT upstream dependencies if needed) through testapp/demo app and run all activities to avoid regressions
  • I have tested via a test drive, or a simulation/mock location app
  • New and existing unit tests pass locally with my changes

We found a Maps SDK upstream 🐛:

Puck animation is jumpy in the examples in which animateCamera API is used instead of the tracking mode, e.g. RerouteActivity

mapboxMap.animateCamera(CameraUpdateFactory.newCameraPosition(cameraPosition), 2000);

👀

maps_8_2_0_puck_jumpy

We tracked ☝️ down and changes were introduced in the alpha.1. @LukasPaczos confirmed that internally the mode is reset even if it’s the same and if the camera mode is set, it works https://github.com/mapbox/mapbox-navigation-android/tree/lp-jumpy-reroute

  • Bump mapboxMapSdk version to 8.2.1 when upstream fix is available

Upstream ticket 👉 mapbox/mapbox-gl-native#15246

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have updated the CHANGELOG including this PR

@Guardiola31337 Guardiola31337 added bug Defect to be fixed. ⚠️ DO NOT MERGE PR should not be merged! blocked: upstream labels Jul 29, 2019
@Guardiola31337 Guardiola31337 added this to the v0.42.0 milestone Jul 29, 2019
@Guardiola31337 Guardiola31337 self-assigned this Jul 29, 2019
Copy link
Contributor

@abhishek1508 abhishek1508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Guardiola31337
Copy link
Contributor Author

Confirming that mapbox/mapbox-gl-native#15265 fixes the Maps SDK upstream issue 🎉

As soon as Maps SDK patch release is available and after bumping mapboxMapSdk we can merge here.

cc @LukasPaczos

@Guardiola31337 Guardiola31337 changed the title Bump mapbox-android-sdk version to 8.2.0 Bump mapbox-android-sdk version to 8.2.1 Jul 31, 2019
@codecov-io
Copy link

Codecov Report

Merging #2013 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2013   +/-   ##
=========================================
  Coverage     41.61%   41.61%           
  Complexity     1290     1290           
=========================================
  Files           288      288           
  Lines          9209     9209           
  Branches        682      682           
=========================================
  Hits           3832     3832           
  Misses         5060     5060           
  Partials        317      317

@Guardiola31337 Guardiola31337 merged commit 3c6a80f into master Jul 31, 2019
@Guardiola31337 Guardiola31337 deleted the pg-bump-maps-8.2.0 branch July 31, 2019 21:11
@Guardiola31337 Guardiola31337 mentioned this pull request Sep 20, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defect to be fixed. ⚠️ DO NOT MERGE PR should not be merged!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building layer is hiding location component
3 participants