Include Codecov reports to Github PR checks #3663
Conversation
Guardiola31337
force-pushed
the
pg-2655-codecov
branch
from
122531d
to
4893fba
Compare
| @@ -73,7 +73,7 @@ assemble-core-release: | |||
|
|
|||
| .PHONY: core-unit-tests | |||
| core-unit-tests: | |||
| $(call run-gradle-tasks,$(CORE_MODULES),test) | |||
There was a problem hiding this comment.
Jacoco is slow and heavy, could you add a separate makefile command for tests with coverage so that it doesn't impact the duration of tests that we run during local development?
There was a problem hiding this comment.
Interesting, checked the CI building times and sometimes they even take longer
This build -> 9m 17s / 2m 26s https://app.circleci.com/pipelines/github/mapbox/mapbox-navigation-android/9084/workflows/e494e304-e6c5-4d10-bbd7-9a8f4a339e1d/jobs/33801
#3661 build -> 12m 45s / 3m 4s https://app.circleci.com/pipelines/github/mapbox/mapbox-navigation-android/9090/workflows/1b3e8626-1735-4867-a43b-30d123b7a072/jobs/33832 (not sure if we added a bunch of low tests as part of #3661)
#3664 build -> 9m 12s / 2m 15s https://app.circleci.com/pipelines/github/mapbox/mapbox-navigation-android/9085/workflows/38332f8f-217f-4988-bedb-6a55816a2f70/jobs/33808
Will add a separate command to scratch a couple of seconds 👍
Guardiola31337
force-pushed
the
pg-2655-codecov
branch
from
4893fba
to
1e5301e
Compare
Codecov Report
@@ Coverage Diff @@
## master #3663 +/- ##
============================================
+ Coverage 39.30% 48.08% +8.77%
+ Complexity 2322 1568 -754
============================================
Files 550 293 -257
Lines 20088 12218 -7870
Branches 1919 1298 -621
============================================
- Hits 7896 5875 -2021
+ Misses 11254 5755 -5499
+ Partials 938 588 -350 |
circle.yml
Outdated
| @@ -16,6 +16,7 @@ workflows: | |||
| - unit-tests: | |||
There was a problem hiding this comment.
Do we need to run these if we're already running jacoco ones? Looks like duplication.
There was a problem hiding this comment.
I thought that was your concern 😅
There was a problem hiding this comment.
My concern was not to change the makefile commands to jacoco because we run them locally as well. On CI, we can run only the jacoco ones 🙃
There was a problem hiding this comment.
#3663 (comment) Ohh you meant only exposing it in the Makefile to use it locally 👍
Guardiola31337
force-pushed
the
pg-2655-codecov
branch
from
1e5301e
to
52dc0d2
Compare
Description
Includes Codecov reports to Github PR checks
Fixes #2655
bug,feature,new API(s),SEMVER, etc.)Goal
Include Codecov reports to Github PR checks so we can see how we're doing on every PR.
Implementation
Update
core-unit-testsandui-unit-testsMakefileso that Jacoco test reports are generete and updatecircle.ymlso they're post to Codecov.ioTesting
Checklist
CHANGELOGincluding this PRapi/current.txtfiles after running$> make core-update-api(Core) /$> make ui-update-api(UI) if there are changes / errors we're 🆗 with (e.g.AddedMethodchanges are marked as errors but don't break SemVer) 🚀 If there are SemVer breaking changes add theSEMVERlabel. See Metalava docs