Running CI tests on iOS 17 (#4586)

* Add iOS CI job to CI * Add reference screenshots * Add iOS 17 exception to testReturnRouteShieldIfIncorrectUrls
mapbox · Jan 24, 2024 · 7f0ead7 · 7f0ead7
1 parent c976919
commit 7f0ead7
Show file tree

Hide file tree

Showing 69 changed files with 22 additions and 9 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -875,6 +875,14 @@ workflows:
             device: "iPhone 14 Pro Max"
             codecoverage: false
             context: Slack Orb
+        - build-job:
+            name: "Xcode_15.2_iOS_17.2_SPM_Debug"
+            xcode: "15.2"
+            iOS: "17.2"
+            device: "iPhone 15 Pro Max"
+            spm: true
+            codecoverage: true
+            context: Slack Orb
         - build-job:
             name: "Xcode_14.1_iOS_16.1_SPM_Debug"
             xcode: "14.1"

diff --git a/Tests/MapboxCoreNavigationTests/NavigationStatusTests.swift b/Tests/MapboxCoreNavigationTests/NavigationStatusTests.swift
@@ -156,15 +156,20 @@ final class NavigationStatusTests: TestCase {
         XCTAssertNil(representation1.shield)
         XCTAssertNil(representation1.imageBaseURL)
 
-        let shield2 = Shield(baseUrl: "|||", displayRef: "ref", name: "shield", textColor: "")
-        let roadNonValidImageBaseUrlString = RoadName(text: "name",
-                                                      language: "",
-                                                      imageBaseUrl: "|||",
-                                                      shield: shield2)
-        let status2 = status(with: [roadNonValidImageBaseUrlString])
-        let representation2 = status2.routeShieldRepresentation
-        XCTAssertNil(representation2.shield)
-        XCTAssertNil(representation2.imageBaseURL)
+        if #available(iOS 17.0, *) {
+            // These URLs are considered valid on iOS 17+
+            // https://developer.apple.com/documentation/foundation/url/3126806-init
+        } else {
+            let shield2 = Shield(baseUrl: "|||", displayRef: "ref", name: "shield", textColor: "")
+            let roadNonValidImageBaseUrlString = RoadName(text: "name",
+                                                          language: "",
+                                                          imageBaseUrl: "|||",
+                                                          shield: shield2)
+            let status2 = status(with: [roadNonValidImageBaseUrlString])
+            let representation2 = status2.routeShieldRepresentation
+            XCTAssertNil(representation2.shield)
+            XCTAssertNil(representation2.imageBaseURL)
+        }
 
         let shield3 = Shield(baseUrl: "", displayRef: "ref", name: "shield", textColor: "")
         let roadEmptyImageBaseUrlString = RoadName(text: "name",

diff --git a/...ssalViewControllerSnapshotTests/testBannerDismissalViewControllerDayStyle.1.png b/...ssalViewControllerSnapshotTests/testBannerDismissalViewControllerDayStyle.1.png
diff --git a/...alViewControllerSnapshotTests/testBannerDismissalViewControllerNightStyle.1.png b/...alViewControllerSnapshotTests/testBannerDismissalViewControllerNightStyle.1.png
diff --git a/.../iPhone16_2/17.2/BottomBannerSnapshotTests/testBottomBannerViewController.1.png b/.../iPhone16_2/17.2/BottomBannerSnapshotTests/testBottomBannerViewController.1.png
diff --git a/...2/17.2/BottomBannerSnapshotTests/testBottomBannerViewControllerNoSafeArea.1.png b/...2/17.2/BottomBannerSnapshotTests/testBottomBannerViewControllerNoSafeArea.1.png
diff --git a/...__/iPhone16_2/17.2/CarPlayCompassViewSnapshotTests/testCarPlayCompassView.1.png b/...__/iPhone16_2/17.2/CarPlayCompassViewSnapshotTests/testCarPlayCompassView.1.png
diff --git a/...__/iPhone16_2/17.2/CarPlayCompassViewSnapshotTests/testCarPlayCompassView.2.png b/...__/iPhone16_2/17.2/CarPlayCompassViewSnapshotTests/testCarPlayCompassView.2.png
diff --git a/...FeedbackViewControllerSnapshotTests/testDayDetailedFeedbackViewController.1.png b/...FeedbackViewControllerSnapshotTests/testDayDetailedFeedbackViewController.1.png
diff --git a/...FeedbackViewControllerSnapshotTests/testDayDetailedFeedbackViewController.2.png b/...FeedbackViewControllerSnapshotTests/testDayDetailedFeedbackViewController.2.png
diff --git a/..._2/17.2/FeedbackViewControllerSnapshotTests/testDayFeedbackViewController.1.png b/..._2/17.2/FeedbackViewControllerSnapshotTests/testDayFeedbackViewController.1.png
diff --git a/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.1.png b/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.1.png
diff --git a/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.2.png b/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.2.png
diff --git a/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.3.png b/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.3.png
diff --git a/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.4.png b/...edbackViewControllerSnapshotTests/testNightDetailedFeedbackViewController.4.png
diff --git a/.../17.2/FeedbackViewControllerSnapshotTests/testNightFeedbackViewController.1.png b/.../17.2/FeedbackViewControllerSnapshotTests/testNightFeedbackViewController.1.png
diff --git a/...e16_2/17.2/InstructionsBannerViewSnapshotTests/testAbbreviateInstructions.1.png b/...e16_2/17.2/InstructionsBannerViewSnapshotTests/testAbbreviateInstructions.1.png
diff --git a/...tionsBannerViewSnapshotTests/testAbbreviateInstructionsIncludingDelimiter.1.png b/...tionsBannerViewSnapshotTests/testAbbreviateInstructionsIncludingDelimiter.1.png
diff --git a/.../17.2/InstructionsBannerViewSnapshotTests/testAbbreviateWestFremontAvenue.1.png b/.../17.2/InstructionsBannerViewSnapshotTests/testAbbreviateWestFremontAvenue.1.png
diff --git a/..._/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testAdjacentShields.1.png b/..._/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testAdjacentShields.1.png
diff --git a/...ots__/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testExitShields.1.png b/...ots__/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testExitShields.1.png
diff --git a/...uctionsBannerViewSnapshotTests/testGenericShieldAndExitViewHighlightColor.1.png b/...uctionsBannerViewSnapshotTests/testGenericShieldAndExitViewHighlightColor.1.png
diff --git a/...onsBannerViewSnapshotTests/testGenericShieldAndExitViewWithCustomDayStyle.1.png b/...onsBannerViewSnapshotTests/testGenericShieldAndExitViewWithCustomDayStyle.1.png
diff --git a/...__/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testGenericShields.1.png b/...__/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testGenericShields.1.png
diff --git a/...2/InstructionsBannerViewSnapshotTests/testInstructionsAndNextInstructions.1.png b/...2/InstructionsBannerViewSnapshotTests/testInstructionsAndNextInstructions.1.png
diff --git a/...ts__/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testLongDistance.1.png b/...ts__/iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testLongDistance.1.png
diff --git a/.../iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testMultilinePrimary.1.png b/.../iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testMultilinePrimary.1.png
diff --git a/..._2/17.2/InstructionsBannerViewSnapshotTests/testPrimaryShieldAndSecondary.1.png b/..._2/17.2/InstructionsBannerViewSnapshotTests/testPrimaryShieldAndSecondary.1.png
diff --git a/...iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testSinglelinePrimary.1.png b/...iPhone16_2/17.2/InstructionsBannerViewSnapshotTests/testSinglelinePrimary.1.png
diff --git a/...7.2/InstructionsBannerViewSnapshotTests/testSinglelinePrimaryAndSecondary.1.png b/...7.2/InstructionsBannerViewSnapshotTests/testSinglelinePrimaryAndSecondary.1.png
diff --git a/...sBannerViewSnapshotTests/testSinglelinePrimaryAndSecondaryWithNightShield.1.png b/...sBannerViewSnapshotTests/testSinglelinePrimaryAndSecondaryWithNightShield.1.png
diff --git a/...ctionsBannerViewSnapshotTests/testSinglelinePrimaryAndSecondaryWithShield.1.png b/...ctionsBannerViewSnapshotTests/testSinglelinePrimaryAndSecondaryWithShield.1.png
diff --git a/...Phone16_2/17.2/InstructionsBannerViewSnapshotTests/testSweEngLongDistance.1.png b/...Phone16_2/17.2/InstructionsBannerViewSnapshotTests/testSweEngLongDistance.1.png
diff --git a/...ne16_2/17.2/InstructionsBannerViewSnapshotTests/testUkrainianLongDistance.1.png b/...ne16_2/17.2/InstructionsBannerViewSnapshotTests/testUkrainianLongDistance.1.png
diff --git a/...apshots__/iPhone16_2/17.2/InstructionsCardSnapshotTests/testLanesManeuver.1.png b/...apshots__/iPhone16_2/17.2/InstructionsCardSnapshotTests/testLanesManeuver.1.png
diff --git a/...shots__/iPhone16_2/17.2/InstructionsCardSnapshotTests/testRegularManeuver.1.png b/...shots__/iPhone16_2/17.2/InstructionsCardSnapshotTests/testRegularManeuver.1.png
diff --git a/...hots__/iPhone16_2/17.2/InstructionsCardSnapshotTests/testTertiaryManeuver.1.png b/...hots__/iPhone16_2/17.2/InstructionsCardSnapshotTests/testTertiaryManeuver.1.png
diff --git a/...Tests/__Snapshots__/iPhone16_2/17.2/LaneSnapshotTests/verifyAllLanes-size.1.png b/...Tests/__Snapshots__/iPhone16_2/17.2/LaneSnapshotTests/verifyAllLanes-size.1.png
diff --git a/...Tests/__Snapshots__/iPhone16_2/17.2/LaneSnapshotTests/verifyAllLanes-size.2.png b/...Tests/__Snapshots__/iPhone16_2/17.2/LaneSnapshotTests/verifyAllLanes-size.2.png
diff --git a/...7.2/ManeuverArrowSnapshotTests/testManeuverArrowHandlesWaypointsCorrectly.1.png b/...7.2/ManeuverArrowSnapshotTests/testManeuverArrowHandlesWaypointsCorrectly.1.png
diff --git a/...nTests/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testArrive.1.png b/...nTests/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testArrive.1.png
diff --git a/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testArriveNone.1.png b/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testArriveNone.1.png
diff --git a/...sts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testLeftUTurn.1.png b/...sts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testLeftUTurn.1.png
diff --git a/...__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testManeuverTypes.1.png b/...__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testManeuverTypes.1.png
diff --git a/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testMergeRight.1.png b/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testMergeRight.1.png
diff --git a/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testRightUTurn.1.png b/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testRightUTurn.1.png
diff --git a/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testRoundabout.1.png b/...ts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testRoundabout.1.png
diff --git a/...pshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testRoundaboutTurnLeft.1.png b/...pshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testRoundaboutTurnLeft.1.png
diff --git a/...pshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testStraightRoundabout.1.png b/...pshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testStraightRoundabout.1.png
diff --git a/...sts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testTurnRight.1.png b/...sts/__Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testTurnRight.1.png
diff --git a/...Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testTurnSlightRight.1.png b/...Snapshots__/iPhone16_2/17.2/ManeuverViewSnapshotTests/testTurnSlightRight.1.png
diff --git a/..._/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testInfiniteMUTCDSpeedLimit.1.png b/..._/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testInfiniteMUTCDSpeedLimit.1.png
diff --git a/..._/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testInfiniteVennaSpeedLimit.1.png b/..._/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testInfiniteVennaSpeedLimit.1.png
diff --git a/...Tests/__Snapshots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testMUTCD.1.png b/...Tests/__Snapshots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testMUTCD.1.png
diff --git a/...napshots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testMUTCD_blueText.1.png b/...napshots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testMUTCD_blueText.1.png
diff --git a/...__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testUnknownMUTCDSpeedLimit.1.png b/...__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testUnknownMUTCDSpeedLimit.1.png
diff --git a/..._/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testUnknownViennaSpeedLimit.1.png b/..._/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testUnknownViennaSpeedLimit.1.png
diff --git a/...ests/__Snapshots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testVienna.1.png b/...ests/__Snapshots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testVienna.1.png
diff --git a/...shots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testVienna_blueBorder.1.png b/...shots__/iPhone16_2/17.2/SpeedLimitViewSnapshotTests/testVienna_blueBorder.1.png
diff --git a/...__/iPhone16_2/17.2/UserHaloCourseViewSnapshotTests/testUserHaloCourseView.1.png b/...__/iPhone16_2/17.2/UserHaloCourseViewSnapshotTests/testUserHaloCourseView.1.png
diff --git a/...CourseViewSnapshotTests/testUserHaloCourseViewColorWhenChangingAppearance.1.png b/...CourseViewSnapshotTests/testUserHaloCourseViewColorWhenChangingAppearance.1.png
diff --git a/...CourseViewSnapshotTests/testUserHaloCourseViewColorWhenChangingAppearance.2.png b/...CourseViewSnapshotTests/testUserHaloCourseViewColorWhenChangingAppearance.2.png
diff --git a/.../UserHaloCourseViewSnapshotTests/testUserHaloCourseViewMultipleDrawCycles.1.png b/.../UserHaloCourseViewSnapshotTests/testUserHaloCourseViewMultipleDrawCycles.1.png
diff --git a/.../UserHaloCourseViewSnapshotTests/testUserHaloCourseViewMultipleDrawCycles.2.png b/.../UserHaloCourseViewSnapshotTests/testUserHaloCourseViewMultipleDrawCycles.2.png
diff --git a/...pshotTests/testUserPuckCourseViewFillAndShadowColorWhenChangingAppearance.1.png b/...pshotTests/testUserPuckCourseViewFillAndShadowColorWhenChangingAppearance.1.png
diff --git a/...pshotTests/testUserPuckCourseViewFillAndShadowColorWhenChangingAppearance.2.png b/...pshotTests/testUserPuckCourseViewFillAndShadowColorWhenChangingAppearance.2.png
diff --git a/...seViewSnapshotTests/testUserPuckCourseViewPuckColorWhenChangingAppearance.1.png b/...seViewSnapshotTests/testUserPuckCourseViewPuckColorWhenChangingAppearance.1.png
diff --git a/...seViewSnapshotTests/testUserPuckCourseViewPuckColorWhenChangingAppearance.2.png b/...seViewSnapshotTests/testUserPuckCourseViewPuckColorWhenChangingAppearance.2.png
diff --git a/...hone16_2/17.2/UserPuckCourseViewSnapshotTests/testUserPuckCourseViewScale.1.png b/...hone16_2/17.2/UserPuckCourseViewSnapshotTests/testUserPuckCourseViewScale.1.png