Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapboxNavigationNative umbrella header omits several headers #2394

Closed
IodaMikeMapbox opened this issue Jun 8, 2020 · 7 comments
Closed

MapboxNavigationNative umbrella header omits several headers #2394

IodaMikeMapbox opened this issue Jun 8, 2020 · 7 comments
Assignees
@vmihaylenko
Labels
bug Something isn’t working build Issues related to builds and dependency management. release blocker Needs to be resolved before the release.

Comments

@IodaMikeMapbox
Copy link
Contributor

MapboxNavigationNative v9 doesn't include headers: 'MBHistoryPlayer.h', 'MBGetRouteCallback.h', 'MBSetRouteCallback.h', 'MapboxNavigationNativeHistoryPlayer.h', 'MBGetTraceAttributesCallback.h', 'MBUpdateSensorDataCallback.h', 'MBConfigureRouterCallback.h', 'MBLocateCallback.h', 'MBIterationResult.h', 'MBGetStatusCallback.h', 'MBUpdateLocationCallback.h', 'MBChangeRouteLegCallback.h', 'MBPushHistoryCallback.h'.
Our CI tests fail because of the generated warnings about that, this is a potential problem for subsequent core work, and it blocks any prerelease.

@mapbox/navnative
@IodaMikeMapbox IodaMikeMapbox added bug Something isn’t working build Issues related to builds and dependency management. labels Jun 8, 2020
@1ec5
Copy link
Contributor

1ec5 commented Jun 9, 2020 •
edited
Loading

https://app.circleci.com/pipelines/github/mapbox/mapbox-navigation-ios/960/workflows/6d3cad76-bd95-470b-99d5-715bf38a8293/jobs/15604/steps

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBHistoryPlayer.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBGetRouteCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBSetRouteCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MapboxNavigationNativeHistoryPlayer.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBGetTraceAttributesCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBUpdateSensorDataCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBConfigureRouterCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBLocateCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBIterationResult.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBGetStatusCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBUpdateLocationCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBChangeRouteLegCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBPushHistoryCallback.h'

@1ec5 1ec5 changed the title Umbrella header for MapboxNavigationNative v9 MapboxNavigationNative umbrella header omits several headers Jun 9, 2020
@1ec5 1ec5 mentioned this issue Jun 9, 2020
Merged
14 tasks
@vmihaylenko
Copy link

I guess we fixed this in further releases

@vmihaylenko
Copy link

https://app.circleci.com/pipelines/github/mapbox/mapbox-navigation-ios/960/workflows/6d3cad76-bd95-470b-99d5-715bf38a8293/jobs/15604/steps

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBHistoryPlayer.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBGetRouteCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBSetRouteCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MapboxNavigationNativeHistoryPlayer.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBGetTraceAttributesCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBUpdateSensorDataCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBConfigureRouterCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBLocateCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBIterationResult.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBGetStatusCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBUpdateLocationCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBChangeRouteLegCallback.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBPushHistoryCallback.h'

this one contains types from a PR which wasn't even merged

@nishant-karajgikar nishant-karajgikar mentioned this issue Jun 18, 2020
Merged
@1ec5
Copy link
Contributor

1ec5 commented Jun 23, 2020 •
edited
Loading

As of MapboxNavigationNative v9.2.1 and #2412, the umbrella header still lacks three header includes:

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBXFeature.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBXGeometry.h'

    - WARN  | xcodebuild:  <module-includes>:1:1: warning: umbrella header for module 'MapboxNavigationNative' does not include header 'MBXExpected.h'

@1ec5 1ec5 added the release blocker Needs to be resolved before the release. label Jun 23, 2020
@1ec5
Copy link
Contributor

1ec5 commented Jun 23, 2020

These three include statements are still missing from the umbrella header in MapboxNavigationNative v14.1.1.

@captainbarbosa captainbarbosa mentioned this issue Jun 24, 2020
Merged
@1ec5
Copy link
Contributor

1ec5 commented Jun 30, 2020

Likely fixed in MapboxNavigationNative v14.1.2.

@1ec5
Copy link
Contributor

1ec5 commented Jul 13, 2020

Fixed in MapboxNavigationNative v14.x.

@1ec5 1ec5 closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmihaylenko vmihaylenko

Labels
bug Something isn’t working build Issues related to builds and dependency management. release blocker Needs to be resolved before the release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@1ec5 @vmihaylenko @IodaMikeMapbox