Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Jazzy theme #2181

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Update Jazzy theme #2181

merged 1 commit into from
Jul 23, 2019

Conversation

captainbarbosa
Copy link
Contributor

Edits Jazzy generation script to support realm/jazzy#1077.

Requires mapbox/jazzy-theme#9 to merge before merging.

cc @1ec5

@captainbarbosa captainbarbosa requested a review from 1ec5 July 15, 2019 20:50
@captainbarbosa captainbarbosa self-assigned this Jul 15, 2019
@captainbarbosa captainbarbosa mentioned this pull request Jul 15, 2019
Merged
@captainbarbosa
Copy link
Contributor Author

Running scripts/document.sh results in ${RELEASE_VERSION} being 0.17.0, which is slightly unexpected to me given that our release page says we're on 0.35.0:

Screenshot 2019-07-15 13 44 34

@1ec5
Copy link
Contributor

1ec5 commented Jul 15, 2019

Running scripts/document.sh results in ${RELEASE_VERSION} being 0.17.0, which is slightly unexpected to me given that our release page says we're on 0.35.0:

You may need to run git fetch --tags to make sure your clone contains all the tags used to calculate the latest release version.

1ec5
1ec5 reviewed Jul 15, 2019
View reviewed changes
scripts/document.sh Outdated Show resolved Hide resolved
@captainbarbosa captainbarbosa changed the title Update doc generation to include title and module version Update Jazzy theme Jul 19, 2019
1ec5
1ec5 approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@1ec5 1ec5 merged commit 7ae6e4e into master Jul 23, 2019
@1ec5 1ec5 deleted the jazzy-updates branch July 23, 2019 16:39
@1ec5
Copy link
Contributor

1ec5 commented Aug 1, 2019

Requires mapbox/jazzy-theme#9 to merge before merging.

I missed this bit. This SDK doesn’t depend on jazzy-theme yet; it hosts its own copy of the theme. We’ll need to make the change here:

mapbox-navigation-ios/docs/theme/templates/header.mustache

Line 7 in 4b22a68

<span class='header-tag'>BRANDLESS_DOCSET_TITLE Reference</span>

@1ec5 1ec5 added the op-ex Refactoring, Tech Debt or any other operational excellence work. label Aug 1, 2019
@1ec5 1ec5 mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees

@captainbarbosa captainbarbosa

Labels
documentation op-ex Refactoring, Tech Debt or any other operational excellence work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@captainbarbosa @1ec5