Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guidance Cards][Part 2]Defer to UIAppearance proxy for color/font literals #2402

Merged
merged 7 commits into from
Aug 4, 2020
Merged

[Guidance Cards][Part 2]Defer to UIAppearance proxy for color/font literals #2402

merged 7 commits into from
Aug 4, 2020

Commits on Aug 3, 2020

  1. Defer to UIAppearance proxy for color/font literals

    @nishant-karajgikar @avi-c
    nishant-karajgikar authored and avi-c committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    2d00fff View commit details
    Browse the repository at this point in the history

  2. Move cornerRadius property of InstructionsCardContainerView from Styl… 

    …e to UIAppearance proxy.
    @avi-c
    avi-c committed Aug 3, 2020
    Configuration menu
    Copy the full SHA
    e75fbf1 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2020

  1. Regenerated UI test snapshot fixtures to match new defaults for Guida… 

    …nce Card styling.
    @avi-c
    avi-c committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    692e865 View commit details
    Browse the repository at this point in the history

  2. Generate test fixture assets for guidance cards iPhone 8 Plus on iOS … 

    …13.5 since iPhone 6 Plus is not supported in that OS but we test for it in CI.
    @avi-c
    avi-c committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    f9fcde7 View commit details
    Browse the repository at this point in the history

  3. Remove references to InstructionsCardStyle to complete move to UIAppe… 

    …arance proxy based styling of Guidance Cards.
    @avi-c
    avi-c committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    469ecc9 View commit details
    Browse the repository at this point in the history

  4. Remove Guidance Card custom styling class tests. Rely on UI tests onl… 

    …y for now.
    @avi-c
    avi-c committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    6dd9d8d View commit details
    Browse the repository at this point in the history

  5. Merge pull request #2510 from mapbox/avic/styleGuidanceCardsPt4 

    [Guidance Cards][Part 4] Remove InstructionsCardStyle class
    @avi-c
    avi-c authored Aug 4, 2020
    Configuration menu
    Copy the full SHA
    6b05d8a View commit details
    Browse the repository at this point in the history