Add waypoint handling #270

bsudekum · 2017-06-08T21:38:16Z

To do:

Add waypoint handling to example app
Improve instructions upon approaching leg destination
~~[x] Add UI elements for arriving and leaving waypoint~~

/cc @1ec5 @frederoni @cammace @ericrwolfe

1ec5 · 2017-06-09T17:07:15Z

MapboxNavigation/RouteTableViewController.swift

@@ -72,14 +72,14 @@ extension RouteTableViewController: UITableViewDelegate, UITableViewDataSource {
    }

    func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
-        return routeController.routeProgress.currentLeg.steps.count
+        return routeController.routeProgress.allSteps.count


Instead of flattening the list of steps, we should have multiple sections (instead of just one), each section listing the steps for a single leg.

bsudekum · 2017-06-13T19:24:17Z

Some notes,

I deprecated destination. It was never really needed and with waypoints, things get a little more confusing if there is a destination option.
didArriveAt changed to now return the route step since there really is not a destination annotation anymore. It also will only return when the user arrives at the end of the route. However, we could change this to return at ever waypoint.
In terms of how this will fit into existing code bases, I think it would just work. There are improvements we could make to how waypoints are handled (adding a UI namely), but as a first step, I think this is good and would unblock any users looking for waypoint support.

/cc @1ec5 @frederoni

1ec5 · 2017-06-13T20:26:58Z

MapboxCoreNavigation/RouteController.swift

+                routeProgress.remainingWaypoints.count > 1 {
+                routeProgress.legIndex += 1
+                routeProgress.currentLegProgress.stepIndex = 0
+                routeProgress.currentLegProgress.alertUserLevel = .depart


Changing legIndex automatically resets currentLegProgress.

1ec5 · 2017-06-13T20:29:32Z

MapboxNavigation/NavigationViewController.swift

@@ -124,8 +124,10 @@ public class NavigationViewController: NavigationPulleyViewController, RouteMapV
     on the destination of your route. The last coordinate of the route will be
     used if no destination is given.
    */
+    @available(*, deprecated, message: "Destination is no longer support nor necessary. A destination annotation will automatically be added to map given the route.")


Note that this shouldn’t have much of an impact on most developers: it isn’t possible to customize this annotation (#213) other than changing its title, subtitle, and coordinates, and none of those properties are likely to be modified by the developer anyways.

@1ec5 it was actually added in #268

Ah, I missed that we’re exposing navigationMapView(_:imageFor:). In any case, that method will continue to work; it just won’t be possible to say something like if annotation == navigationViewController.destination.

1ec5 · 2017-06-13T20:29:48Z

MapboxNavigation/NavigationViewController.swift

@@ -124,8 +124,10 @@ public class NavigationViewController: NavigationPulleyViewController, RouteMapV
     on the destination of your route. The last coordinate of the route will be
     used if no destination is given.
    */
+    @available(*, deprecated, message: "Destination is no longer support nor necessary. A destination annotation will automatically be added to map given the route.")


s/support/supported/

1ec5 · 2017-06-13T20:31:17Z

MapboxNavigation/NavigationViewController.swift

-            annotation.coordinate = route.coordinates!.last!
-            destination = annotation
+        for leg in route.legs {
+            if let last = leg.steps.last {


This code only places an annotation at the last destination. Should we annotate the intermediate waypoints as well?

@1ec5 hrm, no this annotates the last step of each leg. Or at least it's supposed to.

You’re right, I misread this line.

1ec5 · 2017-06-13T20:32:05Z

MapboxNavigation/NavigationViewController.swift

-            let annotation = MGLPointAnnotation()
-            annotation.coordinate = route.coordinates!.last!
-            destination = annotation
+        for leg in route.legs {


If we’re only looking at the last step, there’s no need to iterate over all the steps:

if let lastStep = route.legs.last?.steps.last {

1ec5 · 2017-06-13T20:37:39Z

MapboxNavigation/NavigationViewController.swift

-            navigationDelegate?.navigationViewController?(self, didArriveAt: destination)
+
+        if routeProgress.currentLegProgress.alertUserLevel == .arrive,
+            routeProgress.remainingWaypoints.count == 0 {


Should the developer be notified when the user reaches an intermediate waypoint? I could see use cases for only responding to the final arrival and for responding to intermediate arrivals as well. Perhaps the delegate method should have an additional argument, numberOfWaypointsRemaining, to allow the developer to distinguish between the two cases.

@1ec5 I was thinking about this but wanted to keep the API the same. I think if we want to notify them when they reach a waypoint, we should either rename the method or add a new method for waypoints.

The method’s current name implies that it’s called whenever the user reaches a waypoint once we added support for multiple waypoints. Why else would it take a second argument?

How about we add a new method, navigationViewControllerDidArrive(_:), that gets called after navigationViewController(_:didArriveAt:) when arriving at the final waypoint?

Changed it to a single method that returns the waypoint the user is arriving at for each and every waypoint.

1ec5 · 2017-06-13T20:41:08Z

MapboxNavigation/RouteTableViewController.swift

+    }
+
+    func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {
+        return "Leg \(section + 1)"


The leg number is unimportant to the user. Instead, we should title the section with either of the following formats, preferably the first one:

“Biloxi to Mobile” (see leg.source, leg.destination)

“I-10” (see leg.name)

Blocked by mapbox/mapbox-directions-swift#135.

1ec5 · 2017-06-13T20:41:24Z

MapboxNavigation/RouteTableViewController.swift

+    }
+
+    func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {
+        return "Leg \(section + 1)"


If there is only one leg, there’s no need for a section header.

1ec5 · 2017-06-13T20:41:50Z

MapboxNavigation/RouteTableViewController.swift


-        cell.step = leg.steps[indexPath.row]
+         cell.step = legs[indexPath.section].steps[indexPath.row]


Nit: funky indentation.

1ec5 · 2017-06-13T20:51:32Z

MapboxNavigation/RouteTableViewController.swift


-        if routeController.routeProgress.currentLegProgress.stepIndex + 1 > indexPath.row {
+        if  routeController.routeProgress.legIndex + 1 > indexPath.section && routeController.routeProgress.currentLegProgress.stepIndex + 1 > indexPath.row  {


If the user is on step 5 of leg 1, only the first five steps of section 0 are dimmed out.

@1ec5 I think that's how it should work though. Are you saying the current step should be dimmed?

If leg 0 has 10 steps, leg 1 has 10 steps, and the user is on step 5 of leg 2 which has 10 steps, why would all three legs be halfway dimmed?

Actually, this code is incorrect but in a different way than I first thought. This code is equivalent to: if currentLegIndex >= section && currentLegProgress.stepIndex >= row { dim the cell }. Now if the user is on step 5 of leg 2, the only dimmed cells are those that meet both the following criteria:

the section number is at least 2; and

the row number is at least 5

In other words:

Sections 0 and 1 are completely lit, because they fail criteria (1). 🙅‍♂️

Section 2 is dimmed up to row 4 and lit beginning with row 5. 👍

Sections 3, 4, etc. are each dimmed up to row 4 but lit beginning with row 5, because rows 5 and beyond fail criteria (2). 🙅‍♂️

1ec5 · 2017-06-14T07:16:59Z

MapboxNavigation/RouteTableViewController.swift

+            return nil
+        }
+
+        let legToFrom = routeController.routeProgress.route.legs[section].description.components(separatedBy: ", ")


RouteLeg.description is equivalent to RouteLeg.name. name lists the main streets along the leg, not the leg’s origin and destination. For example, name might be “Market Street, I-10, Main Street”. If you want “Biloxi” and “Mobile”, you need to look at the name properties of RouteLeg’s source and destination properties, which won’t be very useful until mapbox/mapbox-directions-swift#135 is fixed.

bsudekum · 2017-06-19T16:45:13Z

This is ready for another round of reviews

1ec5 · 2017-06-20T07:57:59Z

MapboxNavigation/NavigationViewController.swift

@@ -20,7 +20,7 @@ public protocol NavigationViewControllerDelegate {
    /**
     Called when the user arrives at the destination.
     */
-    @objc optional func navigationViewController(_ navigationViewController : NavigationViewController, didArriveAt destination: MGLAnnotation)
+    @objc optional func navigationViewController(_ navigationViewController : NavigationViewController, didArriveAt destination: Waypoint)


If this gets called on every waypoint, then destination should be waypoint.

1ec5 · 2017-06-20T08:00:51Z

MapboxNavigation/NavigationViewController.swift

@@ -20,7 +20,7 @@ public protocol NavigationViewControllerDelegate {
    /**
     Called when the user arrives at the destination.
     */
-    @objc optional func navigationViewController(_ navigationViewController : NavigationViewController, didArriveAt destination: MGLAnnotation)
+    @objc optional func navigationViewController(_ navigationViewController : NavigationViewController, didArriveAt destination: Waypoint)


Should we also add navigationViewControllerDidArrive(_:) (with only one argument of type NavigationViewController)?

I think one method is good enough here.

1ec5 · 2017-06-20T08:02:30Z

MapboxNavigation/NavigationViewController.swift

@@ -332,6 +328,10 @@ public class NavigationViewController: NavigationPulleyViewController, RouteMapV
        mapViewController?.notifyAlertLevelDidChange(routeProgress: routeProgress)
        tableViewController?.notifyAlertLevelDidChange()

+        if routeProgress.currentLegProgress.alertUserLevel == .arrive {
+            navigationDelegate?.navigationViewController?(self, didArriveAt: routeProgress.route.routeOptions.waypoints[routeProgress.legIndex + 1])


We should pass in the current route leg’s destination waypoint. Otherwise, if we pass in one of the waypoints used to request the route, its location won’t necessarily correspond to what the Directions API thinks the destination should be (after snapping or whatever).

1ec5 · 2017-06-20T08:05:00Z

MapboxNavigation/RouteMapViewController.swift

+        for leg in route.legs {
+            if let last = leg.steps.last {
+                let annotation = MGLPointAnnotation()
+                annotation.coordinate = last.coordinates!.last!


#270 (comment)

1ec5 · 2017-06-20T08:07:50Z

MapboxNavigation/RouteTableViewController.swift

+        }
+
+        let sectionName = routeController.routeProgress.route.legs[section].name
+        let legToFrom = sectionName.components(separatedBy: ", ")


The suggestion in #270 (comment) was to use source and destination, not name.

I added using source and destination but I also left this code in place for cases where we do not have source and destination.

1ec5 · 2017-06-20T08:31:49Z

MapboxNavigation/RouteTableViewController.swift


-        if routeController.routeProgress.currentLegProgress.stepIndex + 1 > indexPath.row {
+        if routeController.routeProgress.legIndex + 1 > indexPath.section && routeController.routeProgress.currentLegProgress.stepIndex + 1 > indexPath.row  {


#270 (comment)

@1ec5 having a hard time getting something to work here. Have any ideas how to accomplish this?

We need to dim a cell for either of two reasons:

Either it represents a step that’s part of a leg that the user has already completed,

Or it represents a completed step in the current leg.

So the correct logic would be:

if indexPath.section < routeController.routeProgress.legIndex || (indexPath.section == routeProgress.legIndex && indexPath.row <= routeProgress.currentLegProgress.stepIndex) { // dim the cell }

1ec5 · 2017-06-20T17:42:17Z

MapboxNavigation/RouteTableViewController.swift

+            return "\(sourceName) to \(destinationName)"
+        }
+
+        let legToFrom = leg.name.components(separatedBy: ", ")
        if legToFrom.count == 2 {
            return "\(legToFrom[0]) to \(legToFrom[1])"


Since these are two road names, “Main Street and Market Street” would be clearer than “Main Street to Market Street”.

1ec5 · 2017-07-06T06:56:33Z

Blocked by Project-OSRM/osrm-text-instructions.swift#24.

1ec5 · 2017-07-09T04:59:42Z

Examples/Swift/ViewController.swift

-        getRouteButton.isHidden = false
-        clearMapButton.isHidden = false
+        if waypoints.count > 1 {
+            waypoints = Array(waypoints.suffix(1))


Nit: use dropFirst().

1ec5 · 2017-07-09T05:00:55Z

Examples/Swift/ViewController.swift

-    @IBAction func didTapClearmap(_ sender: Any) {
-        mapView.removeAnnotations(mapView.annotations ?? [])
+    @IBAction func replay(_ sender: Any) {
+        let bundle = Bundle(for: ViewController.self)


This class is inside the application target, so you can say simply Bundle.main. It’s only necessary to use Bundle(for:) inside a framework, since the framework isn’t the main bundle.

1ec5 · 2017-07-09T05:05:09Z

Examples/Swift/ViewController.swift

+}
+
+extension ViewController: WaypointConfirmationViewControllerDelegate {
+    func confirmationControllerDidConfirm(controller confirmationController: WaypointConfirmationViewController) {


The first part of this selector, confirmationControllerDidConfirm, already contains “confirmation controller”, so controller can be _.

This code path would be a lot cleaner with an unwind segue instead of the delegate pattern…

1ec5 · 2017-07-09T05:09:25Z

MapboxCoreNavigation/RouteProgress.swift

+     Intializes a new `RouteProgress`.
+
+     - parameter route: The route to follow.
+     - parameter legIndex: Zero-based index indicating the current leg the user is on.


legIndex is the index of the leg to start on.

1ec5 · 2017-07-09T05:15:06Z

MapboxNavigation/RouteTableViewController.swift

+
+        let legToFrom = leg.name.components(separatedBy: ", ")
+        if legToFrom.count == 2 {
+            return "\(legToFrom[0]) to \(legToFrom[1])"


Not sure why GitHub thinks #270 (comment) is outdated, but it’s still current.

1ec5 · 2017-07-09T05:18:57Z

MapboxNavigation/RouteTableViewController.swift

+        let sourceName = leg.source.name
+        let destinationName = leg.destination.name
+
+        if let sourceName = sourceName?.nonEmptyString, let destinationName = destinationName?.nonEmptyString {


If the source is the user’s unnamed current location and the destination is a named location, we should say “Destination via Street Name and Street Name”.

If the source is a named location and the destination is unnamed for some reason, we should say “Street Name and Street Name”, same as below.

bsudekum · 2017-08-23T23:24:45Z

More reviews are welcome if anyone is up for it @1ec5 @frederoni.

1ec5

Thanks for your patience. Some more feedback below.

1ec5 · 2017-08-23T23:41:31Z

MapboxNavigation/NavigationMapView.swift

@@ -24,7 +24,7 @@ open class NavigationMapView: MGLMapView {
    let arrowLayerStrokeIdentifier = "arrowStrokeLayer"
    let arrowCasingSymbolLayerIdentifier = "arrowCasingSymbolLayer"
    let arrowSymbolSourceIdentifier = "arrowSymbolSource"
-    let isOpaqueIdentifier = "isOpaqueIdentifier"
+    let isCurrentLeg = "isCurrentLeg"


The name isCurrentLeg implies that it’s a Boolean. Since this string is being used as an attribute name, call it currentLegAttribute but give it the value isCurrentLeg.

1ec5 · 2017-08-23T23:43:12Z

MapboxNavigation/NavigationMapView.swift

@@ -239,7 +239,7 @@ open class NavigationMapView: MGLMapView {

    func shape(for waypoints: [Waypoint]) -> MGLShape? {
        var features = [MGLPointFeature]()
-        let letters = (97...122).map({Character(UnicodeScalar($0))}).map { String(describing:$0).uppercased() }
+        let letters = String.localizedStringWithFormat(NSLocalizedString("ALPHABET", bundle: .mapboxNavigation, value: "ABCDEFGHIJKLMNOPQRSTUVWXYZ", comment: "Format string for alphabet;")).components(separatedBy: "")


Use an actual separator like a space, because some locales may have multi-character letters in the alphabet, like “IJ” in Dutch.

1ec5 · 2017-08-23T23:46:17Z

MapboxNavigation/NavigationMapView.swift

@@ -239,7 +239,7 @@ open class NavigationMapView: MGLMapView {

    func shape(for waypoints: [Waypoint]) -> MGLShape? {
        var features = [MGLPointFeature]()
-        let letters = (97...122).map({Character(UnicodeScalar($0))}).map { String(describing:$0).uppercased() }
+        let letters = String.localizedStringWithFormat(NSLocalizedString("ALPHABET", bundle: .mapboxNavigation, value: "ABCDEFGHIJKLMNOPQRSTUVWXYZ", comment: "Format string for alphabet;")).components(separatedBy: "")


Stray semicolon at the end of the comment. Make sure to point out that each letter should be separated by a space.

1ec5 · 2017-08-23T23:47:32Z

MapboxNavigation/NavigationMapView.swift

+        for (waypointIndex, waypoint) in waypoints.enumerated() {
+            let feature = MGLPointFeature()
+            feature.coordinate = waypoint.coordinate
+            feature.attributes = [ "name": letters[waypointIndex] ]


A reminder to simplify this code by inlining the letters array, as requested in #270 (comment) and #270 (comment).

This seems a bit unreadable IMO:

for (waypointIndex, waypoint) in waypoints.enumerated() { let feature = MGLPointFeature() feature.coordinate = waypoint.coordinate feature.attributes = [ "name": String.localizedStringWithFormat(NSLocalizedString("ALPHABET", bundle: .mapboxNavigation, value: "ABCDEFGHIJKLMNOPQRSTUVWXYZ", comment: "Format string for alphabet;")).characters.map { String(describing: $0) }[waypointIndex] ] features.append(feature) }

Ah, the code I suggested in #270 (comment) was much more readable, but it no longer makes sense with the localization that we’re doing. How about this:

let letters = NSLocalizedString("ALPHABET", bundle: .mapboxNavigation, value: "ABCDEFGHIJKLMNOPQRSTUVWXYZ", comment: "Base letters in the alphabet for labeling waypoints, separated by spaces").components(separatedBy: " ") // then in the for loop feature.attributes = ["name": letters[waypointIndex]]

Note that there doesn’t need to be a format string, just an plain localized string.

1ec5 · 2017-08-23T23:48:21Z

MapboxNavigation/NavigationMapView.swift

+        for (waypointIndex, waypoint) in waypoints.enumerated() {
+            let feature = MGLPointFeature()
+            feature.coordinate = waypoint.coordinate
+            feature.attributes = [ "name": letters[waypointIndex] ]


If the waypoint has a name, how about using the first letter of the name by default? That would be in keeping with how iOS represents contacts who lack photos by their initials.

What if one waypoint has a name and the other does not? So it'd look like B (for picking up bobby) and then a waypoint with no name B again? Some sort of order makes more sense to me here.

If any of the waypoints has a name, I think it would be better to label the named ones with initials and leave the unnamed ones… unlabeled.

1ec5 · 2017-08-23T23:50:07Z

MapboxNavigation/RouteTableViewController.swift

+        let legToFrom = leg.name.components(separatedBy: ", ")
+
+        if let destinationName = destinationName?.nonEmptyString, legToFrom.count > 1 {
+            return String.localizedStringWithFormat(NSLocalizedString("WAYPOINT_DESTINATION_VIA_WAYPOINTS_FORMAT", bundle: .mapboxNavigation, value: "%@, via %@", comment: "Format for displaying destination and intermediate waypoints; 1 = source ; 2 = destinations"), destinationName, leg.name.replacingOccurrences(of: ", ", with: " \(String.localizedStringWithFormat(NSLocalizedString("AND", bundle: .mapboxNavigation, value: "and", comment: "Format string for and;"))) "))


Stray semicolon at the end of the comment.

1ec5 · 2017-08-23T23:54:27Z

MapboxNavigation/RouteTableViewController.swift

+        let legToFrom = leg.name.components(separatedBy: ", ")
+
+        if let destinationName = destinationName?.nonEmptyString, legToFrom.count > 1 {
+            return String.localizedStringWithFormat(NSLocalizedString("WAYPOINT_DESTINATION_VIA_WAYPOINTS_FORMAT", bundle: .mapboxNavigation, value: "%@, via %@", comment: "Format for displaying destination and intermediate waypoints; 1 = source ; 2 = destinations"), destinationName, leg.name.replacingOccurrences(of: ", ", with: " \(String.localizedStringWithFormat(NSLocalizedString("AND", bundle: .mapboxNavigation, value: "and", comment: "Format string for and;"))) "))


Given that Chinese and some other languages don’t delimit words with spaces, I think we should use a format string instead of interpolating the word “and” into a hard-coded string:

let majorWays = leg.name.components(separatedBy: ", ") let summary = String.localizedStringWithFormat(NSLocalizedString("LEG_MAJOR_WAYS_FORMAT", bundle: .mapboxNavigation, value: "%@ and %@", comment: …), majorWays[0], majorWays[1])

The downside is that this code would only be able to handle two major ways, instead of saying something like “A and B and C and D”, but I think the Directions API only gives us two ways anyways.

1ec5

Almost there! Just one request to rename a constant and a few documentation suggestions.

1ec5 · 2017-08-24T17:52:50Z

MapboxNavigation/NavigationViewController.swift

+    /*
+     Returns an` MGLStyleLayer` that determines the appearance of the circles used to symbolize the remaining waypoints.
+
+     If this method is unimplemented, the navigation map view draws the route remaining waypoints using an `MGLSymbolStyleLayer` whose text is equal to the layer returned from  `navigationMapView(_:shapeFor:)` and will be inserted in the style below the symbol layer in navigationMapView(:waypointSymbolStyleLayerWithIdentifier:).


If I’m not mistaken, this method is called only once, the result doesn’t have to be a circle, and the result is applied to all the waypoints (except the origin), right? In that case, how about:

Returns an MGLStyleLayer that marks the location of each destination along the route when there are multiple destinations. The returned layer is added to the map below the layer returned by navigationMapView(_:waypointSymbolStyleLayerWithIdentifier:source:).

If this method is unimplemented, the navigation map view marks each destination waypoint with a circle.

1ec5 · 2017-08-24T17:53:10Z

MapboxNavigation/NavigationViewController.swift

@@ -95,6 +98,28 @@ public protocol NavigationViewControllerDelegate {
     */
    @objc optional func navigationMapView(_ mapView: NavigationMapView, simplifiedShapeDescribing route: Route) -> MGLShape?

+    /*
+     Returns an` MGLStyleLayer` that determines the appearance of the circles used to symbolize the remaining waypoints.


There’s a syntax error here caused by a space being placed after a backtick instead of before.

1ec5 · 2017-08-24T17:56:54Z

MapboxNavigation/NavigationViewController.swift

+     Returns an` MGLStyleLayer` that determines the appearance of the text used to symbolize the remaining waypoints.
+
+     If this method is unimplemented, the navigation map view draws the route remaining waypoints using an `MGLSymbolStyleLayer` whose text is equal to the layer returned from  `navigationMapView(_:shapeFor:)`.
+     This text will start at the number `1` and continue on label each consecutive waypoint.


Returns an MGLStyleLayer that places an identifying symbol on each destination along the route when there are multiple destinations. The returned layer is added to the map above the layer returned by navigationMapView(_:waypointStyleLayerWithIdentifier:source:).

If this method is unimplemented, the navigation map view labels each destination waypoint with a number, starting with 1 at the first destination, 2 at the second destination, and so on.

1ec5 · 2017-08-24T17:58:06Z

MapboxNavigation/NavigationViewController.swift

+    @objc optional func navigationMapView(_ mapView: NavigationMapView, waypointSymbolStyleLayerWithIdentifier identifier: String, source: MGLSource) -> MGLStyleLayer?
+
+    /**
+     Returns an `MGLShape` that represents the routes waypoints


Typo: “route’s”, and a missing period.

Since the first (origin) waypoint is excluded:

Returns an MGLShape that represents the destination waypoints along the route (that is, excluding the origin).

1ec5 · 2017-08-24T17:59:19Z

MapboxNavigation/NavigationViewController.swift

+    /**
+     Returns an `MGLShape` that represents the routes waypoints
+
+     If this method is unimplemented, the navigation map view represnts the route waypoints using `navigationMapView(_:shapeFor:)`.


Typo: “represents”.

1ec5 · 2017-08-24T18:03:42Z

MapboxNavigation/NavigationMapView.swift

+    let arrowLayerStrokeIdentifier = "arrowStrokeLayer"
+    let arrowCasingSymbolLayerIdentifier = "arrowCasingSymbolLayer"
+    let arrowSymbolSourceIdentifier = "arrowSymbolSource"
+    let isCurrentLeg = "isCurrentLeg"


#270 (comment) got collapsed for some reason: the name isCurrentLeg implies that it’s a Boolean. Since this string is being used as an attribute name, call it currentLegAttribute but give it the value isCurrentLeg.

hervouinc · 2017-08-24T18:46:04Z

🍾🥂

juanwall · 2017-08-25T05:02:48Z

When will multiple waypoints be available?

bsudekum added the ⚠️ DO NOT MERGE PR should not be merged! label Jun 8, 2017

1ec5 reviewed Jun 9, 2017

View reviewed changes

bsudekum mentioned this pull request Jun 9, 2017

Add waypoint arrival instruction Project-OSRM/osrm-text-instructions#111

Merged

bsudekum force-pushed the waypoints branch from 7266ea2 to 7517bed Compare June 13, 2017 19:07

1ec5 reviewed Jun 13, 2017

View reviewed changes

1ec5 reviewed Jun 14, 2017

View reviewed changes

bsudekum force-pushed the waypoints branch from 2c0a500 to 89e5787 Compare June 16, 2017 22:59

bsudekum removed the ⚠️ DO NOT MERGE PR should not be merged! label Jun 16, 2017

bsudekum changed the title ~~Add waypoint handling [WIP]~~ Add waypoint handling Jun 16, 2017

Bobby Sudekum added 8 commits June 19, 2017 16:11

Add waypoint handling

92a1d30

more waypoints

d009fff

Use sections

c33b154

clear map

c6dabb3

remove destination

2c6524a

Updates

382ede6

remove

52b867d

use name

315a681

bsudekum force-pushed the waypoints branch from a70fc92 to 315a681 Compare June 19, 2017 14:12

return waypoint when arriving at each waypoint

cbe2ce1

1ec5 suggested changes Jun 20, 2017

View reviewed changes

Bobby Sudekum added 2 commits June 20, 2017 14:21

Merge branch 'master' into waypoints

988dfd0

update

753814a

1ec5 reviewed Jun 20, 2017

View reviewed changes

bsudekum mentioned this pull request Jun 23, 2017

Separate custom UI example #301

Merged

1 task

Bobby Sudekum added 2 commits July 6, 2017 13:25

Merge branch 'master' into waypoints

275b973

update example

13b4ad1

1ec5 reviewed Jul 9, 2017

View reviewed changes

ericrwolfe modified the milestones: v0.7.0-3, v0.7.0-2 Aug 16, 2017

Bobby Sudekum added 8 commits August 16, 2017 15:38

Merge branch 'master' into waypoints

1ab08d5

remove annotations

1286a2e

Merge branch 'master' into waypoints

9b2f21b

Merge branch 'master' into waypoints

306e55a

Merge branch 'master' into waypoints

518d535

Merge branch 'master' into waypoints

8ef4112

Merge branch 'master' into waypoints

f0dc3d5

Always update

e5eb660

Flip

b9b3555

1ec5 reviewed Aug 24, 2017

View reviewed changes

Bobby Sudekum added 3 commits August 24, 2017 10:02

Update

84a1f34

Make bolder

de69c03

darker gray

5995b2f

1ec5 approved these changes Aug 24, 2017

View reviewed changes

bsudekum mentioned this pull request Aug 24, 2017

Move arrow when maneuver is swiped #532

Merged

Update docs

26fec4b

bsudekum merged commit 5d0e4fd into master Aug 24, 2017

bsudekum deleted the waypoints branch August 24, 2017 18:40

1ec5 mentioned this pull request Aug 25, 2017

Warning - Instance method 'navigationMapView(_:imageFor:)' nearly matches optional requirement 'navigationMapView(_:shapeFor:)' of protocol 'NavigationMapViewDelegate' #533

Closed

captainbarbosa mentioned this pull request Apr 25, 2018

NavigationViewController.destination remains documented despite being deprecated #1335

Closed

1ec5 mentioned this pull request Feb 26, 2019

Allow intermediate waypoints to be marked by annotations #1993

Open

akitchen removed the ✓ ready for review label Mar 6, 2019

1ec5 mentioned this pull request Jul 31, 2020

Route line potentially underlaps roads or buildings #2512

Closed


		cell.step = leg.steps[indexPath.row]
		cell.step = legs[indexPath.section].steps[indexPath.row]


		if routeController.routeProgress.currentLegProgress.stepIndex + 1 > indexPath.row {
		if routeController.routeProgress.legIndex + 1 > indexPath.section && routeController.routeProgress.currentLegProgress.stepIndex + 1 > indexPath.row {

Add waypoint handling #270

Add waypoint handling #270

Conversation

bsudekum commented Jun 8, 2017 • edited Loading

Choose a reason for hiding this comment

bsudekum commented Jun 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Jun 14, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Jun 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 commented Jul 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bsudekum commented Aug 23, 2017

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Aug 24, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hervouinc commented Aug 24, 2017

juanwall commented Aug 25, 2017

bsudekum commented Jun 8, 2017 •

edited

Loading

1ec5 Jun 14, 2017 •

edited

Loading

1ec5 Aug 24, 2017 •

edited

Loading