Correcting setRoutes reason #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameter propagation
Codecov Report
@@ Coverage Diff @@
## release-v2.15 #4513 +/- ##
=================================================
+ Coverage 59.87% 59.95% +0.08%
=================================================
Files 189 189
Lines 21203 21203
=================================================
+ Hits 12696 12713 +17
+ Misses 8507 8490 -17 |
kried
approved these changes
Jul 27, 2023
Udumft
added a commit
that referenced
this pull request
Jul 27, 2023
* vk/NAVIOS-1111-reasons: corrected switching to alternative reason parameter propagation
Udumft
added a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Corrected provided reason to update route when switching to alternative route. This is important to correct logging and Navigator internal functioning.
Implementation
Just added a parameter to
InternalRouter's method instead of introducing one more (3rd) enum with cases for proactive rerouting or switching to alternative.This is an internal change, so no need for a CHANGELOG entry.