Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate LocationLayerPlugin #684

Closed
LukasPaczos opened this issue Sep 17, 2018 · 5 comments
Closed

Deprecate LocationLayerPlugin #684

LukasPaczos opened this issue Sep 17, 2018 · 5 comments
Labels
location-layer-plugin Issues that deal with the location layer module

Comments

@LukasPaczos
Copy link
Contributor

Refs mapbox/mapbox-gl-native#12786.

This ticket tracks deprecation of the LocationLayerPlugin that will happen when the LocationComponent is released in the Maps SDK v6.6.0.

@LukasPaczos LukasPaczos added the location-layer-plugin Issues that deal with the location layer module label Sep 17, 2018
@LukasPaczos LukasPaczos added this to the location-layer-0.9.0 milestone Sep 17, 2018
@zugaldia
Copy link
Member

/cc: @mapbox/maps-android @lilykaiser @chloekraw

@zugaldia
Copy link
Member

will happen when the LocationComponent is released in the Maps SDK

May I suggest we call it LocationManager to match the naming we use on iOS?

@zugaldia
Copy link
Member

By looking at the iOS docs, it seems the actual name for this type of functionality is MGLUserLocationAnnotationView. If so, UserLocationAnnotation (or simply LocationAnnotation) probably is a better name which improves consistency across platforms but I'm open to other options.

@LukasPaczos
Copy link
Contributor Author

Browsing through that doc it looks like in the iOS world the MGLUserLocationAnnotationView is just a view. The camera tracking and location management functionality seem to be embedded into the map. What we are proposing is something that exposes all of those things separately from the map, but since there already is a concept of LocationManager on iOS which has an equivalent in LocationEngine on Android I opted for LocationComponent to indicate that all methods used to display and manipulate the location are enclosed in the component.

At this point, I'd propose sticking with the name, but that's still up for debate.

@zugaldia
Copy link
Member

For future reference and for folks looking for functionality similar to the one provided by the Location Layer Plugin: we've integrated this API into our core Maps SDK and this is now available without requiring any additional plugins. Up to date documentation is available here: https://www.mapbox.com/android-docs/maps/overview/location-component/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
location-layer-plugin Issues that deal with the location layer module
Projects
None yet
Development

No branches or pull requests

2 participants