This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Merge LocationLayerPlugin to the Maps SDK #12786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPaczos
force-pushed
the
lp-bring-back-llp
branch
6 times, most recently
from
d3ce642 to
a599b10
Compare
LukasPaczos
force-pushed
the
lp-bring-back-llp
branch
5 times, most recently
from
7c46e52 to
d1144d7
Compare
LukasPaczos
force-pushed
the
lp-bring-back-llp
branch
from
8beb1b6 to
dfb64fb
Compare
tobrun
approved these changes
Sep 7, 2018
| final class LocationAnimatorCoordinator { | ||
|
|
||
| @SuppressLint("UseSparseArrays") | ||
| final Map<Integer, MapboxAnimator> animatorMap = new HashMap<>(); |
There was a problem hiding this comment.
As indicated by the lint warning, a SparseArray would provide better performance.
LukasPaczos
force-pushed
the
lp-bring-back-llp
branch
2 times, most recently
from
9791888 to
dfb64fb
Compare
danesfeder
approved these changes
Sep 10, 2018
There was a problem hiding this comment.
@LukasPaczos this looks great - awesome job porting / integrating all of this code 🚀
…yerPlugin, now called LocationComponent
… removed location save state
…y location update
LukasPaczos
force-pushed
the
lp-bring-back-llp
branch
from
efe1f76 to
189d18a
Compare
LukasPaczos
force-pushed
the
lp-bring-back-llp
branch
from
189d18a to
59d7a8e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the
LocationLayerPluginto the Maps SDK, making the plugin in itself deprecated. The development and maintenance of the location features will happen in the Maps SDK project from now on.TODO:
Cleanup styling options structureKeepingLocationComponentOptionsseparated from theMapboxMapOptionsSave plugin's stateOpted not to save state to enable greater separation from the Maps SDK. Now, location specific layers and sources are added to the map only whenLocationComponentis activated.