-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maps SDK 7.0.0 and required breaking changes refactoring #789
Maps SDK 7.0.0 and required breaking changes refactoring #789
Conversation
Also, other than the |
Thanks for kicking this off @langsmith!
Let's remove the source code of the
We thought about a different strategy wrt to plugins initialization - let's require a valid and fully loaded Let me run with the above and generally let's push any required changes to this branch without rebasing, we can squash all the commits when merging to |
@LukasPaczos , this means that the latest/current version of the plugin ( |
@langsmith correct, |
bbafd16
to
2049a03
Compare
75938ea
to
58a414a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
...in/java/com/mapbox/mapboxsdk/plugins/testapp/activity/offline/OfflineRegionDetailActivity.kt
Show resolved
Hide resolved
loadingArgumentCaptor.getValue().onWillStartLoadingMap(); | ||
|
||
ArgumentCaptor<Style.OnStyleLoaded> styleLoadedArgumentCaptor = ArgumentCaptor.forClass(Style.OnStyleLoaded.class); | ||
verify(mapboxMap).getStyle(styleLoadedArgumentCaptor.capture()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting construct this ArgumentCaptor
This pr bumps the plugins' Maps SDK dependency to
7.0.0-beta.1
in preparation for the stable7.0.0
release. This pr also refactors all of the plugins to fix breaking changes.mapbox/mapbox-android-demo#917 is related.
After commenting out the test app activities which are related to the
LocationLayerPlugin
, I got the test app running again. All of the non-LocationLayerPlugin
activities are running and behaving fine for me. I encourage you to switch to this branch, comment outLocationLayerPlugin
.kt
files, and check out the app on your own device.@tobrun & @LukasPaczos :
In some files, I declare
private Style style;
, setthis.style = mapboxMap.getStyle();
in the initialization of the class, and then useif (style!=null)
in various places throughout the class before running whatever code. Didn't know if that's preferred or if it's fine for us to just domapboxMap.getStyle.XXXX
instead.Wasn't sure how to handle the mix of breaking changes and the deprecation of the location layer plugin. How should we proceed with it?