Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 4.x support #173

Closed
springmeyer opened this issue Sep 9, 2015 · 3 comments
Closed

Node 4.x support #173

springmeyer opened this issue Sep 9, 2015 · 3 comments

Comments

@springmeyer
Copy link
Contributor

Node 4.x mostly works, but will keep this open until all tests are passing and we're able to expose in the travis testing matrix.

Currently 4.x is broken in testing by gyp ERR! stack Error: Invalid version number: -Dfoo=bar which is due to nodejs/node-gyp#720.
springmeyer pushed a commit that referenced this issue Sep 9, 2015
Avoid testing node 4.x until #173 is fixed
35de49c
@mikemorris mikemorris mentioned this issue Sep 9, 2015
Closed
@ChALkeR
Copy link

ChALkeR commented Sep 10, 2015

Adding to the list: nodejs/node#2798.

@leerlemoniii leerlemoniii mentioned this issue Sep 20, 2015
Open
@springmeyer
Copy link
Contributor Author

nodejs/node-gyp#720 is fixed so the node 4.1.x release should avoid that problem. Testing 4.1.x I'm now seeing:

6) complex builds app2 app2 via remote passes tests --custom_include_path=../include --debug:
     Uncaught AssertionError: 'npm WARN package.json node-pre-gyp-test-app2@0.1.0-release1.release2+build1.build2 No license field.\n' == ''

refs npm/npm#5253. Trying to workaround like bf0e093

@springmeyer
Copy link
Contributor Author

bf0e093, closing.

@snyk-bot snyk-bot mentioned this issue Oct 20, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@springmeyer @ChALkeR