Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for single-level module_path when packing #371

Merged
merged 4 commits into from
Apr 27, 2018

Commits on Apr 26, 2018

  1. Allow for single-level module_path when packing

    Prior to 0.7.1, a module_path of `./lib` would result in a package
    containing files like this (using `test/app8` as an example):
    
        lib/app8.node
    
    The switch to tar 3 in 0.7.1 causes the same package to end up like
    this:
    
        package.json
        app8.cc
        binding.gyp
        index.js
        README.md
        lib/app8.node
    
    which causes a problem during remote binary installation:
    
        node-pre-gyp ERR! Pre-built binaries not installable for PACKAGE@0.0.1 and node@8.3.0 (node-v57 ABI, glibc) (falling back to source compile with node-gyp)
        node-pre-gyp ERR! Hit error ENOTDIR: Cannot cd into '..dirs/package/lib'
    
    This commit fixes this problem and allows for single-level module_path
    values.
    allenluce committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    1022d6b View commit details
    Browse the repository at this point in the history
  2. Compare apples to apples

    But don't compare Linux to Apple.
    allenluce committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    d399a1e View commit details
    Browse the repository at this point in the history
  3. Use a platform-specific dynamic object extension

    This should work everywhere except AIX.
    allenluce committed Apr 26, 2018
    Configuration menu
    Copy the full SHA
    76bb9b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2018

  1. Fix Win32 file expectations

    This is based on what showed up during an Appveyor run. Someone with
    more Win32 module building experience should verify that these are
    expected and correct.
    allenluce committed Apr 27, 2018
    Configuration menu
    Copy the full SHA
    6801a8b View commit details
    Browse the repository at this point in the history