Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Node.js 12.x support #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomhughes
Copy link
Contributor

No description provided.

@ShirasawaSama
Copy link

ShirasawaSama commented Oct 21, 2019

Cannot be used on electron.

Main thread is suspend. (It looks like an endless loop)

Whether it's in Mian Process, Render Process or WebWorker Process.

Code:

const Zip = require('zipfile')

Verions

  • Electron: 6.0.9
  • Nodejs: 12.4.0
  • v8: 7.6.303.31-electron.0
  • modules: 73
  • uv: 1.29.1
  • napi: 4
  • chrome: 76.0.3809.146

Build

Environment

  • Windows Server 2016
  • Nodejs v12.12.0
  • NPM v6.11.3

Install

.npmrc:

target=6.0.9
runtime=electron
build_from_source=true

Then:

npm i https://github.com/tomhughes/node-zipfile#node12

I really want to use this module, so I hope you can help me fix this bug. Thanks!

@tomhughes
Copy link
Contributor Author

@ShirasawaSama you should open a separate issue for your problem rather than commenting on an unrelated pull request

@ShirasawaSama
Copy link

ShirasawaSama commented Oct 21, 2019

@tomhughes I'm sorry.

However, at present, this PR has not been merged (at least four months), so the current version of zipfile cannot be successfully built on node12.

Therefore, the environment is not the same as that of the original project.

Of course, I would like to thank you very much if you are willing to work with the project leader to fix this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants