Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable automatic test discovery on Linux #146

Open
1ec5 opened this issue Apr 26, 2021 · 1 comment
Open

Enable automatic test discovery on Linux #146

1ec5 opened this issue Apr 26, 2021 · 1 comment

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 26, 2021

As of swiftlang/swift-package-manager#3053 and Swift 5.4, SPM now supports automatic test discovery on Linux. LinuxMain.swift is now deprecated. We should remove that file to take advantage of automatic test discovery, which will eliminate the need to maintain a list of tests by hand. (Looks like we somehow got away with not having an XCTestManifests.swift?)

Currently the Travis configuration for this repository installs Swift 5.0, so we’ll need to upgrade to 5.4; not sure if it’s supported by swiftenv:

- SWIFT_VERSION=5.0 SWIFTENV_ROOT="$HOME/.swiftenv" PATH="$SWIFTENV_ROOT/bin:$SWIFTENV_ROOT/shims:$PATH"

/ref mapbox/mapbox-directions-swift#539
/cc @mapbox/navigation-ios

@1ec5 1ec5 added the build label Apr 26, 2021
@truburt truburt modified the milestones: v2.1 (beta), v2.1 RC Sep 17, 2021
@1ec5 1ec5 modified the milestones: v2.1 RC, v2.1 (beta) Sep 24, 2021
@mapbox-github-ci-issues-4 mapbox-github-ci-issues-4 bot removed this from the v2.1-beta milestone Oct 26, 2021
@S2Ler S2Ler self-assigned this Nov 5, 2021
@S2Ler S2Ler linked a pull request Nov 5, 2021 that will close this issue
@S2Ler
Copy link
Contributor

S2Ler commented Nov 5, 2021

5.4 isn't supported by swiftenv

@S2Ler S2Ler removed their assignment Nov 5, 2021
@1ec5 1ec5 added the blocked label Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants