Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable automatic test discovery on Linux #539

Closed
1ec5 opened this issue Apr 26, 2021 · 1 comment
Closed

Enable automatic test discovery on Linux #539

1ec5 opened this issue Apr 26, 2021 · 1 comment
Assignees
@S2Ler
Labels
build

Comments

@1ec5
Copy link
Contributor

1ec5 commented Apr 26, 2021

As of swiftlang/swift-package-manager#3053 and Swift 5.4, SPM now supports automatic test discovery on Linux. LinuxMain.swift is now deprecated. We should remove that file and XCTestManifests.swift to take advantage of automatic test discovery, which will eliminate the need to maintain a list of tests by hand.

mapbox-directions-swift/CONTRIBUTING.md

Line 57 in 2ffc5f0

1. Rerun `swift test --generate-linuxmain`, which updates [XCTestManifests.swift](./Tests/MapboxDirectionsTests/XCTestManifests.swift) for builds that use Swift Package Manager.

We’ll need to wait until Swift 5.4 makes it into an Xcode image on CircleCI before we can depend on these changes:

mapbox-directions-swift/.circleci/config.yml

Line 42 in 2ffc5f0

- image: swift:5.3

/cc @mapbox/navigation-ios
@1ec5 1ec5 added build blocked Blocked by dependency or unclarity. labels Apr 26, 2021
@1ec5 1ec5 mentioned this issue Apr 26, 2021
Open
@S2Ler S2Ler self-assigned this May 28, 2021
S2Ler added a commit that referenced this issue May 31, 2021
@S2Ler
Upgrade SPM version to 5.4 for Linux builds
d569016 
Fixes #539.

SPM 5.4 has automatic test discovery support, so that we can remove
manually generated files for running Linux tests.
@S2Ler S2Ler mentioned this issue May 31, 2021
Merged
@S2Ler S2Ler added PR Ready and removed blocked Blocked by dependency or unclarity. labels May 31, 2021
@S2Ler
Copy link
Contributor

S2Ler commented Jun 4, 2021

Fixed in #547

@S2Ler S2Ler closed this as completed Jun 4, 2021
@S2Ler S2Ler removed the PR Ready label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S2Ler S2Ler

Labels
build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@S2Ler @1ec5