Various bug fixes for LineString.simplify and Polygon.simplify #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes these bugs, too: - Polygon's simplify method didn't square the tolerance parameter when it should have - Polygon's 'highestQuality = false' didn't work at all(!)
Also removes hard-coded test which had wrong values
Also fix compiling using .xcodeproj file
2 tasks
1ec5
reviewed
Sep 24, 2021
| } | ||
| } | ||
|
|
||
| func XCTAssertEqual(_ expected: [[LocationCoordinate2D]], _ actual: [[LocationCoordinate2D]], accuracy: CLLocationDegrees, _ message: @autoclosure () -> String = "", file: StaticString = #filePath, line: UInt = #line) { |
There was a problem hiding this comment.
Some of the Bitrise builds are failing because #filePath requires Swift 5.3, which is in Xcode 12. The readme currently states a minimum requirement of Xcode 9, but this would be a good opportunity to increase the requirement to 12.
| @@ -0,0 +1,109 @@ | |||
| import Foundation | |||
|
|
|||
| enum Simplifier { | |||
There was a problem hiding this comment.
Interesting use of an enumeration as an effective namespace, rather than a struct that’s more commonly used for this purpose but comes with initializers. This pattern might be worth following elsewhere in the codebase.
1ec5
added
bug
op-ex
1ec5
approved these changes
Sep 24, 2021
|
6ecf55b updates the readme to require Xcode 12.0. |
|
c120ea5 adds the test fixtures to the Xcode project for Carthage-based builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes these issues introduced in the port of turf-simplify from #138:
LineString.simplifywithhighestQuality = falsewas broken as it was usingstart.coordinatein one formula when it should have usedcoordinatePolygon.simplifyignoredhighestQuality = falseas it first assigned theself.coordinatesto a local variable, then simplified theself.coordinates, but then passed the previous local variable to the Douglas-Peucker algorithm. That means it always returned results as ifhighestQuality = truewas set.Polygon.simplifyforgot to square the tolerance to the Douglas-Peucker algorithm (LineString.simplifydid it correctly)Polygon.simplifydidn't simplify if any of the exterior/interior polygons was a triangle; now it just skips simplification of the triangle but simplifies the others.I've also refactored the code to remove the code duplication between
LineString.swiftandPolygon.swift, and ported the turf-simplify test suite using the in/out directory -- excluding the test cases for MultiLineString and MultiPolygon as they aren't supported yet.