Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine all framework target into one #197

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Conversation

OdNairy
Copy link
Contributor

@OdNairy OdNairy commented Aug 26, 2022

Xcode has an option to build different platforms based on a single target.
This kind of setup would simplify support for cross-platform apps/SDKs.

From the technical point of view, I've changed SUPPORTED_PLATFORMS build setting into cross-platform value: iphonesimulator iphoneos macosx appletvos appletvsimulator watchsimulator watchos. SDKROOT was dropped in favor of missing value so Xcode can detect the corresponding SDK based on destination.

I also updated the Bitrise workflow to target the new scheme. I suppose it may be a build issue on different branches until this PR is merged as we store config on bitrise website instead of per-branch.

Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow I missed that Carthage supports universal frameworks: Carthage/Carthage#622. We’ve been setting up all the other Swift service projects the same way over the years without realizing we could get away with a universal framework.

@OdNairy OdNairy merged commit f28d6b9 into main Aug 26, 2022
@OdNairy OdNairy deleted the feature/combined-target branch August 26, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants