Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove iOS 10 support. #198

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Remove iOS 10 support. #198

merged 1 commit into from
Sep 15, 2022

Conversation

MaximAlien
Copy link
Contributor

PR increases minimum deployment targets to:

  • iOS 11.0
  • tvOS 11.0
  • macOS 10.13
  • watchOS 4.0

@MaximAlien MaximAlien requested review from OdNairy and a team September 14, 2022 23:15
@MaximAlien MaximAlien self-assigned this Sep 14, 2022
@@ -6,7 +6,7 @@ import PackageDescription
let package = Package(
name: "Turf",
platforms: [
.macOS(.v10_12), .iOS(.v10), .watchOS(.v3), .tvOS(.v12),
.macOS(.v10_13), .iOS(.v11), .watchOS(.v4), .tvOS(.v11),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that we've correctly set tvOS support to 12.0. It should be 11.0 instead. I haven't made any specific tests, but looks like decreasing version should be safe.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it was set to tvOS 12 in #147; however, I’m unaware of a need to exclude tvOS 11 at this time.

/cc @chezzdev

@MaximAlien MaximAlien merged commit 0550e60 into main Sep 15, 2022
@MaximAlien MaximAlien deleted the maxim/remove-ios-10-support branch September 15, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants