Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting feature ID #7

Closed
hannesj opened this issue Aug 13, 2016 · 4 comments
Closed

Enable setting feature ID #7

hannesj opened this issue Aug 13, 2016 · 4 comments

Comments

@hannesj
Copy link
Contributor

hannesj commented Aug 13, 2016

The VT specification allows features to have an id specified, and geojson-vt passes those trought after mapbox/geojson-vt#70 was merged. Vt-pbf should probably write those ids to the vector tiles.

@anandthakker
Copy link
Contributor

Agreed!

@hannesj
Copy link
Contributor Author

hannesj commented Aug 14, 2016

Should I do a PR (this time including tests) or are you on to this?

@anandthakker
Copy link
Contributor

A PR with unit tests would be much appreciated!

On Sun, Aug 14, 2016 at 10:17 AM Hannes Junnila notifications@github.com
wrote:

Should I do a PR (this time including tests) or are you on to this?


You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#7 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AEvmR4_MqCYUJyVaNtH-C_IIipdl--Qwks5qfyOQgaJpZM4JjrxT
.

hannesj added a commit to hannesj/vt-pbf that referenced this issue Aug 15, 2016
@hannesj
Copy link
Contributor Author

hannesj commented Aug 15, 2016

@anandthakker done as #8

Could you carve out a new release after that one is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants