You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
to suffer from a C++ exception. Because there is no try/catch this exception will lead to an abort which would bring down the entire node process. So, this needs a try/catch to protect from DDOS potential on the API side.
The particular case where I noticed this was this backtrace:
Hey @springmeyer I've added the try/catch logic in #81, but also added some exclude comment for code coverage since I'm not exactly sure to recreate in unit tests. Any ideas?
It is possible for the code inside
vtquery/src/vtquery.cpp
Lines 362 to 418 in c3bad9b
abort
which would bring down the entire node process. So, this needs a try/catch to protect from DDOS potential on the API side.The particular case where I noticed this was this backtrace:
The text was updated successfully, but these errors were encountered: