New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threadpool try/catch audit #16

Closed

springmeyer opened this issue Nov 22, 2016 · 1 comment

Contributor

springmeyer commented Nov 22, 2016

Need to audit node C++ addon code for missing try/catch in async functions.

Cases where missing that have recently been fixed:

Contributor Author

springmeyer commented Apr 4, 2018 •

edited

Loading

Closing:

try/catch is used in node-cpp-skel, so we'll recommend that as a guide.
but this problem still happens with modules based on node-cpp-skel, e.g. Dangerous abort possible in HandleOKCallback vtquery#69. So I've ticketed at node-cpp-skel having try/catch around the After function block by default: try/catch in HandleOKCallback node-cpp-skel#114

springmeyer closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment