Merge pull request #3203 from mapfish/add-noopener

Fix some SonarCloud security and Bug
mapfish · Feb 16, 2024 · 2b74242 · 2b74242
2 parents 15284b1 + e81195b
commit 2b74242
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 10 deletions.
diff --git a/core/src/main/webapp/index.html b/core/src/main/webapp/index.html
@@ -1,6 +1,7 @@
 <!DOCTYPE html>
-<html>
+<html lang="en">
   <head>
+    <title>Mapfish Print</title>
     <meta charset="UTF-8" />
     <link href="favicon.ico" rel="shortcut icon" />
     <script

diff --git a/docs/src/main/resources/templates/_main.html b/docs/src/main/resources/templates/_main.html
@@ -135,7 +135,9 @@ <h1>{{pageTitle}}</h1>
 
               <div role="contentinfo">
                 <p>
-                  <a href="https://www.camptocamp.com/geospatial_solutions" target="_blank">Camptocamp</a>
+                  <a href="https://www.camptocamp.com/geospatial_solutions" target="_blank" rel="noopener"
+                    >Camptocamp</a
+                  >
                   <br />
                   <span class="commit">
                     Revision

diff --git a/docs/src/main/resources/templates/download.html b/docs/src/main/resources/templates/download.html
@@ -1,7 +1,7 @@
 <h4>Source Code</h4>
 <p>
   The source code for Mapfish Print is available on GitHub:
-  <a href="https://github.com/mapfish/mapfish-print" target="_blank">mapfish/mapfish-print</a>.
+  <a href="https://github.com/mapfish/mapfish-print" target="_blank" rel="noopener">mapfish/mapfish-print</a>.
 </p>
 <p>Please feel free to fork and contribute via pull requests and by creating new issues.</p>
 
@@ -44,9 +44,9 @@ <h4 id="war">
 </h4>
 <p>
   The Mapfish Print WAR file is a Java archive that can be ran in any Java Web Application Server like
-  <a href="http://tomcat.apache.org/" target="_blank">Tomcat</a> or
-  <a href="http://www.eclipse.org/jetty/" target="_blank">Jetty</a>. To use Mapfish Print as a standalone Web
-  Application you should:
+  <a href="http://tomcat.apache.org/" target="_blank" rel="noopener">Tomcat</a> or
+  <a href="http://www.eclipse.org/jetty/" target="_blank" rel="noopener">Jetty</a>. To use Mapfish Print as a
+  standalone Web Application you should:
 </p>
 <ul>
   <li>Install Java 7 or later</li>

diff --git a/docs/src/main/resources/templates/index.html b/docs/src/main/resources/templates/index.html
@@ -4,7 +4,7 @@
 </p>
 <p>
   The project is a Java based servlet/library/application based on the mature
-  <a href="https://community.jaspersoft.com/project/jasperreports-library" target="_blank"
+  <a href="https://community.jaspersoft.com/project/jasperreports-library" target="_blank" rel="noopener"
     >Jasper Reports Library</a
   >.
 </p>
@@ -13,16 +13,18 @@
   <p class="last">
     A good way to get started with MapFish Print 3 is to follow the <strong>introduction workshop</strong>.
     Download the workshop
-    <a target="_blank" href="https://mapfish.github.io/mapfish-print-workshop/mfp-workshop.zip">here</a> (zip
-    archive).
+    <a target="_blank" href="https://mapfish.github.io/mapfish-print-workshop/mfp-workshop.zip" rel="noopener"
+      >here</a
+    >
+    (zip archive).
   </p>
 </div>
 <p>Mapfish Print has the following distributions:</p>
 <ul>
   <li>
     The most commonly used distribution is the <em>war</em> distribution where Mapfish Print is a servlet and
     can be run in a servlet container like
-    <a href="https://tomcat.apache.org/" target="_blank">Apache Tomcat</a>.
+    <a href="https://tomcat.apache.org/" target="_blank" rel="noopener">Apache Tomcat</a>.
   </li>
 
   <li>