Clarify log messages

mapfish · May 21, 2024 · 84f9bc2 · 84f9bc2
1 parent 3fdf959
commit 84f9bc2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/core/src/main/java/org/mapfish/print/attribute/DataSourceAttribute.java b/core/src/main/java/org/mapfish/print/attribute/DataSourceAttribute.java
@@ -115,8 +115,7 @@ public void setAttributes(final Map<String, Attribute> attributes) {
     for (Map.Entry<String, Attribute> entry : attributes.entrySet()) {
       Attribute attribute = entry.getValue();
       if (attribute == null) {
-        final String msg =
-            "Attribute: '" + entry.getKey() + "' is not an attribute. It is a: " + null;
+        final String msg = "Attribute: '" + entry.getKey() + "' is not a defined attribute.";
         LOGGER.error("Error setting the Attributes: {}", msg);
         throw new IllegalArgumentException(msg);
       } else {

diff --git a/core/src/main/java/org/mapfish/print/config/Template.java b/core/src/main/java/org/mapfish/print/config/Template.java
@@ -133,8 +133,7 @@ public final void setAttributes(final Map<String, Attribute> attributes) {
     for (Map.Entry<String, Attribute> entry : attributes.entrySet()) {
       Attribute attribute = entry.getValue();
       if (attribute == null) {
-        final String msg =
-            "Attribute: '" + entry.getKey() + "' is not an attribute. It is a: " + null;
+        final String msg = "Attribute: '" + entry.getKey() + "' is not a defined attribute";
         LOGGER.error("Error setting the Attributes: {}", msg);
         throw new IllegalArgumentException(msg);
       } else {
@@ -169,8 +168,8 @@ public final void setProcessors(final List<Processor> processors) {
   private void assertProcessors(final List<Processor> processorsToCheck) {
     for (Processor entry : processorsToCheck) {
       if (entry == null) {
-        final String msg = "Processor: " + null + " is not a processor.";
-        LOGGER.error("Error in the processors to check while setting the Attributes:  {}", msg);
+        final String msg = "Processor is missing.";
+        LOGGER.error("Error in the processors to check while setting the Attributes: {}", msg);
         throw new IllegalArgumentException(msg);
       }
     }