-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support data URLs in the HTTP request factory #1502
Conversation
@sbrunner, I added data:url support to the image layer (and others based on the same http request mechanism). I tested this with some png data:url and it passed:
What do you think? |
It shouldn't use a handler as it's done here? It should be tested throw an example... |
@sbrunner, the ImageLayer and associated factories are using URIs. An Handle only works with URLs. How do you handle it? |
I'm curious to know why it's an URI, but it's another story... |
11986c5
to
a8e95d9
Compare
@sbrunner, the code is now making use of the Handler. Does it look better now? |
Yes :-), and the changes in DataUrlConnection.java can be canceled :-) |
a8e95d9
to
2be0076
Compare
Indeed @sbrunner, I forgot about it. It is done now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :-)
d60d762
to
2de37d6
Compare
439d360
to
81a12bc
Compare
2de37d6
to
5bf49af
Compare
81a12bc
to
aed4409
Compare
@sbrunner, I changed the base to 3.20 so the build should soon pass. |
The data we stream has been decoded to binary, it is no more base64. By the way, there does not exist a base64 content type. See Content-Transfer-Encoding.
aed4409
to
a9d0243
Compare
@sbrunner, as discussed, I rebased this branch on top of master. |
08ee82e
to
06f4978
Compare
No description provided.