Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish to GitHub Package #2411

Merged
merged 2 commits into from
May 4, 2022
Merged

Publish to GitHub Package #2411

merged 2 commits into from
May 4, 2022

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented May 3, 2022

Fix #2390

@sbrunner sbrunner added backport master Backport the pull request to the 'master' branch backport 3.28 Backport the pull request to the '3.28' branch backport 3.29 Backport the pull request to the '3.29' branch labels May 3, 2022
@sbrunner sbrunner requested review from jwkaltz and a user May 3, 2022 12:49
jwkaltz
jwkaltz approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@jwkaltz jwkaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
although I am not sure what the "version = '1.0.0'" implies - is this value not used? Or is this like a default value?

@sbrunner
Copy link
Member Author

sbrunner commented May 4, 2022

Effectively, this version shouldn't be used :-)

@sbrunner sbrunner force-pushed the publish-package branch 2 times, most recently from d7203d0 to 7e75840 Compare May 4, 2022 08:57
@sbrunner sbrunner force-pushed the publish-package branch from 7e75840 to 1ef0110 Compare May 4, 2022 09:16
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sbrunner sbrunner merged commit fb1aee1 into 3.27 May 4, 2022
@sbrunner sbrunner deleted the publish-package branch May 4, 2022 09:34
This was referenced May 4, 2022
Closed
Merged
Merged
This was referenced Aug 25, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwkaltz jwkaltz jwkaltz approved these changes

Assignees
No one assigned
Labels
backport master Backport the pull request to the 'master' branch backport 3.28 Backport the pull request to the '3.28' branch backport 3.29 Backport the pull request to the '3.29' branch no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @jwkaltz